From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org
Subject: Re: [PATCH] net: implement dev_disable_lro() hw_features compatibility
Date: Fri, 18 Mar 2011 12:43:32 -0700 (PDT) [thread overview]
Message-ID: <20110318.124332.242116560.davem@davemloft.net> (raw)
In-Reply-To: <1300471986.2589.26.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 18 Mar 2011 18:13:06 +0000
> Local function declarations are a very bad idea, as they are not checked
> against the function definition. Please declare the function in
> <linux/ethtool.h>; that does not oblige us to export it.
Agreed.
next prev parent reply other threads:[~2011-03-18 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 17:42 [PATCH] net: implement dev_disable_lro() hw_features compatibility Michał Mirosław
2011-03-18 18:13 ` Ben Hutchings
2011-03-18 19:43 ` David Miller [this message]
2011-03-19 2:56 ` [PATCH v2] " Michał Mirosław
2011-03-22 8:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318.124332.242116560.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).