From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: eric.dumazet@gmail.com, bhutchings@solarflare.com, jdb@comx.dk,
netdev@vger.kernel.org, nhorman@tuxdriver.com,
alexander.h.duyck@intel.com
Subject: Re: LRO disable warnings on kernel 2.6.38
Date: Fri, 18 Mar 2011 12:52:21 -0700 (PDT) [thread overview]
Message-ID: <20110318.125221.212667543.davem@davemloft.net> (raw)
In-Reply-To: <20110318081524.42d18bd2@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 18 Mar 2011 08:15:24 -0700
> On Fri, 18 Mar 2011 15:33:04 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> Le vendredi 18 mars 2011 à 14:17 +0000, Ben Hutchings a écrit :
>>
>> > WARN is correct as this is a driver bug. But I agree that the
>> > device/driver ID should be included.
>>
>> stack trace gives absolutely no useful indication here.
>>
>> Bug is in driver, yet we dump information on core network stack ?
>>
>> pr_err() is an error indication, not a warning by the way ;)
>
> The advantage of WARN is that it doesn't get ignored and shows
> up in kernel oops. But agreed it should print out as much device
> info as possible to finger the broken device driver.
Infrastructure is not static, therefore we could add a WARN_ON_NETDEV()
or similar. An in fact such things would probably be very useful.
next prev parent reply other threads:[~2011-03-18 19:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 11:12 LRO disable warnings on kernel 2.6.38 Jesper Dangaard Brouer
2011-03-18 13:05 ` Eric Dumazet
2011-03-18 14:17 ` Ben Hutchings
2011-03-18 14:33 ` Eric Dumazet
2011-03-18 15:15 ` Stephen Hemminger
2011-03-18 19:52 ` David Miller [this message]
2011-03-18 19:58 ` Ben Hutchings
2011-03-18 19:59 ` David Miller
2011-03-18 15:40 ` Ben Hutchings
2011-03-18 16:18 ` Alexander Duyck
2011-03-21 9:21 ` Jesper Dangaard Brouer
2011-03-21 9:45 ` Eric Dumazet
2011-03-21 9:53 ` Eric Dumazet
2011-03-21 10:04 ` Jesper Dangaard Brouer
2011-03-21 10:11 ` Eric Dumazet
2011-03-21 10:27 ` Jesper Dangaard Brouer
2011-03-21 10:00 ` Amit Salecha
2011-03-21 12:34 ` Stanislaw Gruszka
2011-03-21 13:46 ` Stanislaw Gruszka
2011-03-21 13:52 ` Ben Hutchings
2011-03-21 15:10 ` [RFC] net: fix ethtool->set_flags not intended -EINVAL return value Stanislaw Gruszka
2011-03-21 15:15 ` Ben Hutchings
2011-03-22 2:41 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318.125221.212667543.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=jdb@comx.dk \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).