From: David Miller <davem@davemloft.net>
To: eilong@broadcom.com
Cc: ariele@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-dev2.6] bxn2x: Fix location of PCI-ids defines
Date: Fri, 18 Mar 2011 15:13:56 -0700 (PDT) [thread overview]
Message-ID: <20110318.151356.98903139.davem@davemloft.net> (raw)
In-Reply-To: <1300367613.31873.0.camel@lb-tlvb-eilong.il.broadcom.com>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Thu, 17 Mar 2011 15:13:33 +0200
> On Thu, 2011-03-17 at 06:06 -0700, David Miller wrote:
>> From: "Ariel Elior" <ariele@broadcom.com>
>> Date: Thu, 17 Mar 2011 14:27:04 +0200
>>
>> > Signed-off-by: Ariel Elior <ariele@broadcom.com>
>> > Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
>>
>> Unless you intend to reference these symbols elsewhere in the
>> kernel, they should stay private in your driver.
>>
>
> The bnx2i will need it as well. Isn't it better to keep all the PCI IDs
> in the same global location?
It looks like this change propagated to Linus via the scsi tree or
similar, so I don't need to apply it.
prev parent reply other threads:[~2011-03-18 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 12:27 [PATCH net-dev2.6] bxn2x: Fix location of PCI-ids defines Ariel Elior
2011-03-17 13:06 ` David Miller
2011-03-17 13:13 ` Eilon Greenstein
2011-03-17 15:10 ` David Miller
2011-03-17 17:32 ` Michael Chan
2011-03-18 22:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318.151356.98903139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).