* [PATCH] econet: 4 byte infoleak to the network
@ 2011-03-17 11:40 Vasiliy Kulikov
2011-03-17 11:50 ` Phil Blundell
0 siblings, 1 reply; 3+ messages in thread
From: Vasiliy Kulikov @ 2011-03-17 11:40 UTC (permalink / raw)
To: linux-kernel
Cc: security, David S. Miller, Phil Blundell, Eric Dumazet, Tejun Heo,
Nelson Elhage, netdev
struct aunhdr has 4 padding bytes between 'pad' and 'handle' fields on
x86_64. These bytes are not initialized in the variable 'ah' before
sending 'ah' to the network. This leads to 4 bytes kernel stack
infoleak.
This bug was introduced before the git epoch.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
net/econet/af_econet.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c
index 0c28263..116d3fd 100644
--- a/net/econet/af_econet.c
+++ b/net/econet/af_econet.c
@@ -435,10 +435,10 @@ static int econet_sendmsg(struct kiocb *iocb, struct socket *sock,
udpdest.sin_addr.s_addr = htonl(network | addr.station);
}
+ memset(&ah, 0, sizeof(ah));
ah.port = port;
ah.cb = cb & 0x7f;
ah.code = 2; /* magic */
- ah.pad = 0;
/* tack our header on the front of the iovec */
size = sizeof(struct aunhdr);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] econet: 4 byte infoleak to the network
2011-03-17 11:40 [PATCH] econet: 4 byte infoleak to the network Vasiliy Kulikov
@ 2011-03-17 11:50 ` Phil Blundell
2011-03-18 22:15 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Phil Blundell @ 2011-03-17 11:50 UTC (permalink / raw)
To: Vasiliy Kulikov
Cc: linux-kernel, security, David S. Miller, Eric Dumazet, Tejun Heo,
Nelson Elhage, netdev
On Thu, 2011-03-17 at 14:40 +0300, Vasiliy Kulikov wrote:
> struct aunhdr has 4 padding bytes between 'pad' and 'handle' fields on
> x86_64. These bytes are not initialized in the variable 'ah' before
> sending 'ah' to the network. This leads to 4 bytes kernel stack
> infoleak.
>
> This bug was introduced before the git epoch.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Well spotted. Thanks for the patch.
Acked-by: Phil Blundell <philb@gnu.org>
p.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] econet: 4 byte infoleak to the network
2011-03-17 11:50 ` Phil Blundell
@ 2011-03-18 22:15 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-03-18 22:15 UTC (permalink / raw)
To: philb; +Cc: segoon, linux-kernel, security, eric.dumazet, tj, nelhage, netdev
From: Phil Blundell <philb@gnu.org>
Date: Thu, 17 Mar 2011 11:50:01 +0000
> On Thu, 2011-03-17 at 14:40 +0300, Vasiliy Kulikov wrote:
>> struct aunhdr has 4 padding bytes between 'pad' and 'handle' fields on
>> x86_64. These bytes are not initialized in the variable 'ah' before
>> sending 'ah' to the network. This leads to 4 bytes kernel stack
>> infoleak.
>>
>> This bug was introduced before the git epoch.
>>
>> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
>
> Well spotted. Thanks for the patch.
>
> Acked-by: Phil Blundell <philb@gnu.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-18 22:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-17 11:40 [PATCH] econet: 4 byte infoleak to the network Vasiliy Kulikov
2011-03-17 11:50 ` Phil Blundell
2011-03-18 22:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).