From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: rl@hellgate.ch, mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: __ethtool_set_sg: check for function pointer before using it
Date: Fri, 18 Mar 2011 15:15:59 -0700 (PDT) [thread overview]
Message-ID: <20110318.151559.13735292.davem@davemloft.net> (raw)
In-Reply-To: <1300380733.2569.3.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 17 Mar 2011 16:52:13 +0000
> On Thu, 2011-03-17 at 17:37 +0100, Roger Luethi wrote:
>> __ethtool_set_sg does not check if dev->ethtool_ops->set_sg is defined
>> which can result in a NULL pointer dereference when ethtool is used to
>> change SG settings for drivers without SG support.
>>
>> Signed-off-by: Roger Luethi <rl@hellgate.ch>
> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
next prev parent reply other threads:[~2011-03-18 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 16:37 [PATCH] ethtool: __ethtool_set_sg: check for function pointer before using it Roger Luethi
2011-03-17 16:52 ` Ben Hutchings
2011-03-18 22:15 ` David Miller [this message]
2011-03-17 17:00 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318.151559.13735292.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=rl@hellgate.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).