From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: herbert@gondor.hengli.com.au, netdev@vger.kernel.org,
bugzilla-daemon@bugzilla.kernel.org
Subject: Re: [Bug 16572] random panics in bridging on 2.6.34+
Date: Fri, 18 Mar 2011 15:17:04 -0700 (PDT) [thread overview]
Message-ID: <20110318.151704.91345093.davem@davemloft.net> (raw)
In-Reply-To: <20110318090338.2f6dcb5d@nehalam>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 18 Mar 2011 09:03:38 -0700
> On Fri, 18 Mar 2011 10:27:28 -0500
> Herbert Xu <herbert@gondor.hengli.com.au> wrote:
>
>> On Fri, Mar 18, 2011 at 08:10:52AM -0700, Stephen Hemminger wrote:
>> > On Fri, 18 Mar 2011 13:49:03 GMT
>> > bugzilla-daemon@bugzilla.kernel.org wrote:
>> >
>> > > https://bugzilla.kernel.org/show_bug.cgi?id=16572
>> >
>> > Herbert hasn't submitted the patch upstream.
>>
>> Oops! Thanks for reminding me.
>>
>> bridge: Reset IPCB when entering IP stack on NF_FORWARD
>>
>> Whenever we enter the IP stack proper from bridge netfilter we
>> need to ensure that the skb is in a form the IP stack expects
>> it to be in.
>>
>> The entry point on NF_FORWARD did not meet the requirements of
>> the IP stack, therefore leading to potential crashes/panics.
>>
>> This patch fixes the problem.
>>
>> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
prev parent reply other threads:[~2011-03-18 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-16572-100@https.bugzilla.kernel.org/>
[not found] ` <201103181349.p2IDn3Qm024329@demeter2.kernel.org>
[not found] ` <20110318081052.6ca134fb@nehalam>
2011-03-18 15:27 ` [Bug 16572] random panics in bridging on 2.6.34+ Herbert Xu
2011-03-18 16:03 ` Stephen Hemminger
2011-03-18 22:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318.151704.91345093.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).