From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-2.6] ethtool: Compat handling for struct ethtool_rxnfc Date: Fri, 18 Mar 2011 15:17:36 -0700 (PDT) Message-ID: <20110318.151736.57477244.davem@davemloft.net> References: <1300383272.2569.13.camel@bwh-desktop> <4D83BA36.8020301@intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bhutchings@solarflare.com, netdev@vger.kernel.org, santwona.behera@sun.com To: alexander.h.duyck@intel.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:43782 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932988Ab1CRWQ6 (ORCPT ); Fri, 18 Mar 2011 18:16:58 -0400 In-Reply-To: <4D83BA36.8020301@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Alexander Duyck Date: Fri, 18 Mar 2011 13:01:58 -0700 > On 3/17/2011 10:34 AM, Ben Hutchings wrote: >> This structure was accidentally defined such that its layout can >> differ between 32-bit and 64-bit processes. Add compat structure >> definitions and an ioctl wrapper function. >> >> Signed-off-by: Ben Hutchings >> Cc: stable@kernel.org [2.6.30+] >> --- >> David, >> >> I still haven't received any response on whether the >> ETHTOOL_GRXCLSRLALL >> wrapping works with a real driver, but perhaps you could test it >> against >> niu? I think sparc32 and sparc64 have the same alignment for u64 so >> this wrapper isn't strictly necessary, but it would still be used. >> (Or >> we can arrange to disable the conversion when compat_ethtool_rxnfc is >> equivalent to ethtool_rxnfc.) >> >> Ben. > > I've done a bit of testing this morning and verified GRXRINGS, > GRCLSRLCNT, GRXCLSRULE, SRXCLSRLDEL, and SRXCLSRLINS all seem to be > working for 32bit and 64bit ethtool user space on a x86_64 kernel with > the patch. I also verified the original issue was present by running > 32bit ethtool on a x86_64 kernel without the patch applied. ... > Acked-by: Alexander Duyck Applied, thanks.