From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] headers: use __aligned_xx types for userspace
Date: Fri, 18 Mar 2011 16:28:26 -0700 [thread overview]
Message-ID: <20110318162826.5295f130.akpm@linux-foundation.org> (raw)
In-Reply-To: <1300474237-10980-1-git-send-email-vapier@gentoo.org>
On Fri, 18 Mar 2011 14:50:37 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> Now that we finally have __aligned_xx exported to userspace, convert
> the headers that get exported over to the proper type.
>
Sob. Please don't assume that because you're on top of an issue, all
the rest of us are.
A bit of git-log grovelling turns up
: commit 79b5dc0c64d88cda3da23b2e22a5cec0964372ac
: Author: Eric Paris <eparis@redhat.com>
: Date: Fri Oct 15 14:34:14 2010 -0700
: types.h: define __aligned_u64 and expose to userspace
:
: We currently have a kernel internal type called aligned_u64 which aligns
: __u64's on 8 bytes boundaries even on systems which would normally align
: them on 4 byte boundaries. This patch creates a new type __aligned_u64
: which does the same thing but which is exposed to userspace rather than
: being kernel internal.
but that really doesn't tell us why it was merged either. Perhaps that
came out in the followup discussion and I failed to fix the changelog.
Still, it doesn't hurt to educate people. Please explain why we are
making this change?
> include/linux/if_ppp.h | 16 ++++++++--------
> include/linux/netfilter/nfnetlink_log.h | 4 ++--
> include/linux/netfilter/nfnetlink_queue.h | 4 ++--
> include/linux/netfilter/xt_connbytes.h | 4 ++--
> include/linux/netfilter/xt_quota.h | 2 +-
> 5 files changed, 15 insertions(+), 15 deletions(-)
davem stuff :)
next prev parent reply other threads:[~2011-03-18 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 18:50 [PATCH] headers: use __aligned_xx types for userspace Mike Frysinger
2011-03-18 22:17 ` David Miller
2011-03-18 23:28 ` Andrew Morton [this message]
2011-03-18 23:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318162826.5295f130.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).