From: David Miller <davem@davemloft.net>
To: hagen@jauu.net
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH 1/2] socket: increase default maximum listen queue length
Date: Sun, 20 Mar 2011 17:18:16 -0700 (PDT) [thread overview]
Message-ID: <20110320.171816.183049702.davem@davemloft.net> (raw)
In-Reply-To: <20110320235253.GD3038@nuttenaction>
From: Hagen Paul Pfeifer <hagen@jauu.net>
Date: Mon, 21 Mar 2011 00:52:53 +0100
> The number is somewhat magically - like many other values. I greped
> tglx/history.git but the comment (at that time tcp_ipv4.c) seems pre 2002 era.
Then don't use that number as part of the justification for the
change.
Describe what matters, and only what matters. Providing magic and
arbitrary numbers doesn't help people reading your commit message.
next prev parent reply other threads:[~2011-03-21 0:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-20 1:50 [PATCH] socket: increase default maximum listen queue length Hagen Paul Pfeifer
2011-03-20 4:41 ` David Miller
2011-03-20 11:59 ` Hagen Paul Pfeifer
2011-03-20 8:30 ` Eric Dumazet
2011-03-20 9:04 ` Rémi Denis-Courmont
2011-03-20 9:36 ` Eric Dumazet
2011-03-20 11:39 ` Hagen Paul Pfeifer
2011-03-20 11:55 ` Eric Dumazet
2011-03-20 12:14 ` Hagen Paul Pfeifer
2011-03-20 23:04 ` [PATCH 1/2] " Hagen Paul Pfeifer
2011-03-20 23:04 ` [PATCH 2/2] socket: add minimum listen queue length sysctl Hagen Paul Pfeifer
2011-03-21 7:36 ` Eric Dumazet
2011-03-20 23:09 ` [PATCH 1/2] socket: increase default maximum listen queue length David Miller
2011-03-20 23:52 ` Hagen Paul Pfeifer
2011-03-21 0:18 ` David Miller [this message]
2011-03-20 23:57 ` Hagen Paul Pfeifer
-- strict thread matches above, loose matches on Subject: below --
2011-03-25 18:31 Hagen Paul Pfeifer
2011-03-31 5:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110320.171816.183049702.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).