netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: philipp_subx@redfish-solutions.com, netdev@vger.kernel.org,
	linux-atm-general@lists.sourceforge.net
Subject: Re: [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware
Date: Sun, 20 Mar 2011 21:57:04 -0700 (PDT)	[thread overview]
Message-ID: <20110320.215704.193716335.davem@davemloft.net> (raw)
In-Reply-To: <1300676496.26693.318.camel@localhost>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 21 Mar 2011 03:01:36 +0000

> On Sun, 2011-03-20 at 18:52 -0700, Philip Prindeville wrote:
>> The newest FPGA firmware on the Solos processors correctly signals
>> carrier transitions, bitrate, etc.
>> 
>> The driver previously ignored these messages, and the physical state
>> was always ATM_PHY_SIG_UNKNOWN.
>> 
>> Now that the board reports its state, we expose a bug whereby the
>> transition from UNKNOWN to LOST causes us to release all VC's.
>> 
>> We don't delete any VC's, but instead just send an indication of
>> carrier change.
>> 
>> Signed-off-by: Philip A Prindeville <philipp@redfish-solutions.com>
>> ---
>> 
>> --- a/drivers/atm/solos-pci.c	2011-03-20 15:27:40.000000000 -0600
>> +++ b/drivers/atm/solos-pci.c	2011-03-20 16:32:11.000000000 -0600
>> @@ -382,8 +382,10 @@ static int process_status(struct solos_c
>> 
>>   	/* Anything but 'Showtime' is down */
>>   	if (strcmp(state_str, "Showtime")) {
>>   		atm_dev_signal_change(card->atmdev[port], ATM_PHY_SIG_LOST);
>> +#if 0
>>   		atm_dev_release_vccs(card->atmdev[port]);
>> +#endif
> 
> Either remove it or don't.  #if 0 is for people without version control.

Also, this would seem to break those using the older firmware.

  reply	other threads:[~2011-03-21  4:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21  1:52 [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware Philip Prindeville
2011-03-21  3:01 ` Ben Hutchings
2011-03-21  4:57   ` David Miller [this message]
2011-03-21  5:56     ` Philip Prindeville
2011-03-21  6:04       ` David Miller
2011-03-21  7:25         ` Philip Prindeville
2011-04-29 23:09           ` [Linux-ATM-General] " David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110320.215704.193716335.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=philipp_subx@redfish-solutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).