netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yjwei@cn.fujitsu.com
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com
Subject: Re: [PATCH v3] xfrm: Fix initialize repl field of struct xfrm_state
Date: Mon, 21 Mar 2011 18:08:59 -0700 (PDT)	[thread overview]
Message-ID: <20110321.180859.245394202.davem@davemloft.net> (raw)
In-Reply-To: <4D870E2F.50601@cn.fujitsu.com>

From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Mon, 21 Mar 2011 16:37:03 +0800

> Commit 'xfrm: Move IPsec replay detection functions to a separate file'
>   (9fdc4883d92d20842c5acea77a4a21bb1574b495)
> introduce repl field to struct xfrm_state, and only initialize it
> under SA's netlink create path, the other path, such as pf_key,
> ipcomp/ipcomp6 etc, the repl field remaining uninitialize. So if
> the SA is created by pf_key, any input packet with SA's encryption
> algorithm will cause panic.

I'll apply this, thanks.

I know you guys are discussing alternative ways to handle this,
but getting the crash fixed in the simplest way now doesn't hurt.

  reply	other threads:[~2011-03-22  1:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21  5:45 xfrm: Fix initialize repl field of struct xfrm_state Wei Yongjun
2011-03-21  5:48 ` [PATCH] " Wei Yongjun
2011-03-21  5:55 ` David Miller
2011-03-21  6:36   ` Wei Yongjun
2011-03-21  6:46     ` David Miller
2011-03-21  6:49       ` Wei Yongjun
2011-03-21  7:54         ` Steffen Klassert
2011-03-21  7:44       ` [PATCH v2] " Wei Yongjun
2011-03-21  8:00         ` David Miller
2011-03-21  8:01           ` David Miller
2011-03-21  8:37           ` [PATCH v3] " Wei Yongjun
2011-03-22  1:08             ` David Miller [this message]
2011-03-21  8:25       ` Steffen Klassert
2011-03-21  9:10         ` Wei Yongjun
2011-03-21  9:18           ` Wei Yongjun
2011-03-21 12:06             ` Steffen Klassert
2011-03-22  1:04               ` Wei Yongjun
2011-03-22 13:14                 ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110321.180859.245394202.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    --cc=yjwei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).