* [PATCH] snmp: SNMP_UPD_PO_STATS_BH() always called from softirq
@ 2011-03-21 11:30 Eric Dumazet
2011-03-22 1:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2011-03-21 11:30 UTC (permalink / raw)
To: David Miller; +Cc: netdev
We dont need to test if we run from softirq context, we definitely are.
This saves few instructions in ip_rcv() & ip_rcv_finish()
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/include/net/snmp.h b/include/net/snmp.h
index 762e2ab..27461d6 100644
--- a/include/net/snmp.h
+++ b/include/net/snmp.h
@@ -150,7 +150,7 @@ struct linux_xfrm_mib {
#define SNMP_UPD_PO_STATS_BH(mib, basefield, addend) \
do { \
__typeof__(*mib[0]) *ptr = \
- __this_cpu_ptr((mib)[!in_softirq()]); \
+ __this_cpu_ptr((mib)[0]); \
ptr->mibs[basefield##PKTS]++; \
ptr->mibs[basefield##OCTETS] += addend;\
} while (0)
@@ -202,7 +202,7 @@ struct linux_xfrm_mib {
#define SNMP_UPD_PO_STATS64_BH(mib, basefield, addend) \
do { \
__typeof__(*mib[0]) *ptr; \
- ptr = __this_cpu_ptr((mib)[!in_softirq()]); \
+ ptr = __this_cpu_ptr((mib)[0]); \
u64_stats_update_begin(&ptr->syncp); \
ptr->mibs[basefield##PKTS]++; \
ptr->mibs[basefield##OCTETS] += addend; \
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] snmp: SNMP_UPD_PO_STATS_BH() always called from softirq
2011-03-21 11:30 [PATCH] snmp: SNMP_UPD_PO_STATS_BH() always called from softirq Eric Dumazet
@ 2011-03-22 1:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-03-22 1:13 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 21 Mar 2011 12:30:55 +0100
> We dont need to test if we run from softirq context, we definitely are.
>
> This saves few instructions in ip_rcv() & ip_rcv_finish()
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-22 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-21 11:30 [PATCH] snmp: SNMP_UPD_PO_STATS_BH() always called from softirq Eric Dumazet
2011-03-22 1:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).