From: David Miller <davem@davemloft.net>
To: wg@grandegger.com
Cc: jan@linutronix.de, bhupesh.sharma@st.com,
b.spranger@linutronix.de, netdev@vger.kernel.org
Subject: Re: [PATCH] can: c_can: Do basic c_can configuration _before_ enabling the interrupts
Date: Mon, 21 Mar 2011 18:19:35 -0700 (PDT) [thread overview]
Message-ID: <20110321.181935.242136690.davem@davemloft.net> (raw)
In-Reply-To: <4D877E61.5080703@grandegger.com>
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Mon, 21 Mar 2011 17:35:45 +0100
> On 03/21/2011 02:47 PM, Jan Altenberg wrote:
>> Hi all,
>>
>> I ran into some trouble while testing the SocketCAN driver for the BOSCH
>> C_CAN controller. The interface is not correctly initialized, if I put
>> some CAN traffic on the line, _while_ the interface is being started
>> (which means: the interface doesn't come up correcty, if there's some RX
>> traffic while doing 'ifconfig can0 up').
>>
>> The current implementation enables the controller interrupts _before_
>> doing the basic c_can configuration. I think, this should be done the
>> other way round.
>>
>> The patch below fixes things for me.
>>
>> Signed-off-by: Jan Altenberg <jan@linutronix.de>
>
> Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Applied, thanks everyone.
prev parent reply other threads:[~2011-03-22 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 13:47 [PATCH] can: c_can: Do basic c_can configuration _before_ enabling the interrupts Jan Altenberg
2011-03-21 14:49 ` Kurt Van Dijck
2011-03-21 16:35 ` Wolfgang Grandegger
2011-03-22 1:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321.181935.242136690.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b.spranger@linutronix.de \
--cc=bhupesh.sharma@st.com \
--cc=jan@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).