From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: netdev@vger.kernel.org, mirq-linux@rere.qmqm.pl,
eric.dumazet@gmail.com, arnd@arndb.de, greearb@candelatech.com,
kaber@trash.net, daniel.lezcano@free.fr, xemul@openvz.org
Subject: Re: [PATCH] veth: Fix the byte counters
Date: Mon, 21 Mar 2011 18:25:03 -0700 (PDT) [thread overview]
Message-ID: <20110321.182503.258117496.davem@davemloft.net> (raw)
In-Reply-To: <m1oc54i242.fsf@fess.ebiederm.org>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Mon, 21 Mar 2011 14:40:29 -0700
>
> Commit 44540960 "veth: move loopback logic to common location" introduced
> a bug in the packet counters. I don't understand why that happened as it
> is not explained in the comments and the mut check in dev_forward_skb
> retains the assumption that skb->len is the total length of the packet.
>
> I just measured this emperically by setting up a veth pair between two
> noop network namespaces setting and attempting a telnet connection between
> the two. I saw three packets in each direction and the byte counters were
> exactly 14*3 = 42 bytes high in each direction. I got the actual
> packet lengths with tcpdump.
>
> So remove the extra ETH_HLEN from the veth byte count totals.
>
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Applied, thanks.
prev parent reply other threads:[~2011-03-22 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 21:40 [PATCH] veth: Fix the byte counters Eric W. Biederman
2011-03-22 1:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321.182503.258117496.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@free.fr \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=kaber@trash.net \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).