From: David Miller <davem@davemloft.net>
To: marc.zyngier@arm.com
Cc: netdev@vger.kernel.org, steve.glendinning@smsc.com
Subject: Re: [PATCH] NET: smsc95xx: don't use stack for async writes to the device
Date: Tue, 22 Mar 2011 01:02:34 -0700 (PDT) [thread overview]
Message-ID: <20110322.010234.98886588.davem@davemloft.net> (raw)
In-Reply-To: <1300456438-13286-1-git-send-email-marc.zyngier@arm.com>
From: Marc Zyngier <marc.zyngier@arm.com>
Date: Fri, 18 Mar 2011 13:53:58 +0000
> The set_multicast operation performs asynchronous writes to the
> device, with some addresses pointing to the stack. Bad things may
> happen, and this is trapped CONFIG_DMA_API_DEBUG:
...
> Move the two offenders to the private structure which is kmalloc-ed,
> and thus safe.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Steve Glendinning <steve.glendinning@smsc.com>
Applied, thanks.
prev parent reply other threads:[~2011-03-22 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 13:53 [PATCH] NET: smsc95xx: don't use stack for async writes to the device Marc Zyngier
2011-03-22 8:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322.010234.98886588.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=marc.zyngier@arm.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).