From: David Miller <davem@davemloft.net>
To: LW@KARO-electronics.de
Cc: shawn.guo@freescale.com, netdev@vger.kernel.org,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH 3/4] drivers/net/fec: Fix dual MAC support on i.MX28
Date: Tue, 22 Mar 2011 01:07:17 -0700 (PDT) [thread overview]
Message-ID: <20110322.010717.241446116.davem@davemloft.net> (raw)
In-Reply-To: <19848.22512.18596.3017@ipc1.ka-ro>
From: Lothar Waßmann <LW@KARO-electronics.de>
Date: Tue, 22 Mar 2011 09:04:00 +0100
> Shawn Guo writes:
>> > +static int dual_mac;
>> > +module_param(dual_mac, int, S_IRUGO);
>> > +
>>
>> As you are detecting dual_mac in probe function, is this necessary?
>>
> Not really. I added this is only for debugging.
Please do not add driver-specific module parameters.
next prev parent reply other threads:[~2011-03-22 8:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 16:37 [PATCH 0/4] drivers/net/fec: Some cleanups and fix for DUAL MAC mode Lothar Waßmann
2011-03-21 16:37 ` [PATCH 1/4] drivers/net/fec: Cleanup Lothar Waßmann
2011-03-21 16:37 ` [PATCH 2/4] drivers/net/fec: Use constants instead of magic numbers Lothar Waßmann
2011-03-21 16:37 ` [PATCH 3/4] drivers/net/fec: Fix dual MAC support on i.MX28 Lothar Waßmann
2011-03-21 16:37 ` [PATCH 4/4] drivers/net/fec: Don't mess with configured MAC addresses Lothar Waßmann
2011-03-22 7:43 ` Shawn Guo
2011-03-22 7:49 ` Lothar Waßmann
2011-03-22 8:55 ` Shawn Guo
2011-03-22 7:28 ` [PATCH 3/4] drivers/net/fec: Fix dual MAC support on i.MX28 Shawn Guo
2011-03-22 8:04 ` Lothar Waßmann
2011-03-22 8:07 ` David Miller [this message]
2011-03-22 9:22 ` Shawn Guo
2011-03-22 2:50 ` [PATCH 2/4] drivers/net/fec: Use constants instead of magic numbers Shawn Guo
2011-03-22 2:49 ` [PATCH 1/4] drivers/net/fec: Cleanup Shawn Guo
2011-03-22 10:00 ` [PATCH 3/4] drivers/net/fec: Fix dual MAC support on i.MX28 Lothar Waßmann
2011-03-22 10:00 ` [PATCH 4/4] drivers/net/fec: Don't mess with configured MAC addresses Lothar Waßmann
2011-03-22 12:33 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322.010717.241446116.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=LW@KARO-electronics.de \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@freescale.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).