From: David Miller <davem@davemloft.net>
To: gallatin@myri.com
Cc: sgruszka@redhat.com, netdev@vger.kernel.org, brice@myri.com,
stable@kernel.org
Subject: Re: [PATCH] myri10ge: fix rmmod crash
Date: Wed, 23 Mar 2011 12:31:56 -0700 (PDT) [thread overview]
Message-ID: <20110323.123156.15222378.davem@davemloft.net> (raw)
In-Reply-To: <4D89F111.7030506@myri.com>
From: Andrew Gallatin <gallatin@myri.com>
Date: Wed, 23 Mar 2011 09:09:37 -0400
> On 03/23/11 08:44, Stanislaw Gruszka wrote:
>> Rmmod myri10ge crash at free_netdev() -> netif_napi_del(), because
>> napi
>> structures are already deallocated. To fix call netif_napi_del()
>> before
>> kfree() at myri10ge_free_slices().
>
> I apologize; I made a similar fix myself to our tree last fall simply
> forgot to post it to netdev... I'm terribly sorry for the time
> you wasted chasing this. At any rate...
>
> Acked by: Andrew Gallatin <gallatin@myri.com>
Patch applied, thanks everyone.
prev parent reply other threads:[~2011-03-23 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 12:44 [PATCH] myri10ge: fix rmmod crash Stanislaw Gruszka
2011-03-23 13:09 ` Andrew Gallatin
2011-03-23 19:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323.123156.15222378.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brice@myri.com \
--cc=gallatin@myri.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).