From: David Miller <davem@davemloft.net>
To: yevgenyp@mellanox.co.il
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org,
eugenia@mellanox.co.il
Subject: Re: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i
Date: Wed, 23 Mar 2011 12:36:43 -0700 (PDT) [thread overview]
Message-ID: <20110323.123643.200348134.davem@davemloft.net> (raw)
In-Reply-To: <953B660C027164448AE903364AC447D20705BE28@mtldag01.mtl.com>
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Date: Wed, 23 Mar 2011 15:10:34 +0000
>>
>> This is an abuse of the ethtool_drvinfo::driver field.
>>
>> Your users can use lspci -v, can't they?
>>
> I don't think there is a problem here.
> We have always reported the HW model via Ethtool, we just expanded the information
> we provide.
> Our users prefer to see the information in ethtool.
This doesn't matter, we strive for consistency across drivers rather
than have special cases like this.
Please remove the chip variant information from the ethtool driver
string, it is absolutely not appropriate.
next prev parent reply other threads:[~2011-03-23 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 8:38 [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i Yevgeny Petrilin
2011-03-23 14:04 ` Ben Hutchings
2011-03-23 15:10 ` Yevgeny Petrilin
2011-03-23 15:46 ` Ben Hutchings
2011-03-23 15:54 ` Yevgeny Petrilin
2011-03-23 16:08 ` Ben Hutchings
2011-03-23 17:06 ` Stephen Hemminger
2011-03-23 15:58 ` Stephen Hemminger
2011-03-23 19:36 ` David Miller [this message]
2011-03-24 3:40 ` Ben Hutchings
2011-03-24 6:26 ` Yevgeny Petrilin
2011-03-23 19:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323.123643.200348134.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eugenia@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).