From: Stephen Hemminger <shemminger@vyatta.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: netdev@vger.kernel.org, Andrew Gallatin <gallatin@myri.com>,
Brice Goglin <brice@myri.com>
Subject: Re: [RFC] myri10ge: small rx_done refactoring
Date: Wed, 23 Mar 2011 08:33:57 -0700 [thread overview]
Message-ID: <20110323083357.457f10aa@nehalam> (raw)
In-Reply-To: <20110323124939.GA7834@redhat.com>
On Wed, 23 Mar 2011 13:52:04 +0100
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Add lro_enable variable to read NETIF_F_LRO flag only once per napi poll
> call. This should fix theoretical race condition with
> myri10ge_set_rx_csum() and myri10ge_set_flags() where flag NETIF_F_LRO
> can be changed.
You may need a barrier or the race may still be there.
The driver seems to use mb() where wmb() is intended, and never use rmb()?
--
next prev parent reply other threads:[~2011-03-23 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 12:52 [RFC] myri10ge: small rx_done refactoring Stanislaw Gruszka
2011-03-23 15:21 ` Andrew Gallatin
2011-03-23 15:33 ` Stephen Hemminger [this message]
2011-03-24 8:16 ` Stanislaw Gruszka
2011-03-24 15:15 ` Stephen Hemminger
2011-03-24 15:59 ` Stanislaw Gruszka
2011-03-24 16:42 ` Ben Hutchings
2011-03-24 17:29 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323083357.457f10aa@nehalam \
--to=shemminger@vyatta.com \
--cc=brice@myri.com \
--cc=gallatin@myri.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).