From: David Miller <davem@davemloft.net>
To: jluebbe@debian.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix IP timestamp option (IPOPT_TS_PRESPEC) handling in ip_options_echo()
Date: Thu, 24 Mar 2011 16:20:05 -0700 (PDT) [thread overview]
Message-ID: <20110324.162005.71589730.davem@davemloft.net> (raw)
In-Reply-To: <1300988662-13204-1-git-send-email-jluebbe@debian.org>
From: Jan Luebbe <jluebbe@debian.org>
Date: Thu, 24 Mar 2011 18:44:22 +0100
> - if (soffset + 8 <= optlen) {
> + if (soffset + 7 <= optlen) {
I don't see how you can legally reduce this check from 8 to 7 bytes.
> + if (inet_addr_type(dev_net(skb_dst(skb)->dev), addr) != RTN_UNICAST) {
> dopt->ts_needtime = 1;
> soffset += 8;
> }
Yet keep this code which advances soffset by 8.
next prev parent reply other threads:[~2011-03-24 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 17:44 [PATCH] Fix IP timestamp option (IPOPT_TS_PRESPEC) handling in ip_options_echo() Jan Luebbe
2011-03-24 23:20 ` David Miller [this message]
2011-03-25 6:11 ` Jan Lübbe
2011-03-28 1:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324.162005.71589730.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jluebbe@debian.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).