From: David Miller <davem@davemloft.net>
To: mathieu.poirier@linaro.org
Cc: steve.glendinning@smsc.com, netdev@vger.kernel.org,
lee.jones@linaro.org, patches@linaro.org,
linus.walleij@linaro.org
Subject: Re: [PATCH] net: allow shifted address in smsc911x
Date: Fri, 25 Mar 2011 14:31:03 -0700 (PDT) [thread overview]
Message-ID: <20110325.143103.25112180.davem@davemloft.net> (raw)
In-Reply-To: <1301088437-31915-1-git-send-email-mathieu.poirier@linaro.org>
From: mathieu.poirier@linaro.org
Date: Fri, 25 Mar 2011 15:27:17 -0600
> From: Alessandro Rubini <rubini@gnudd.com>
>
> At least one device I'm using needs address shifting to access
> registers in the LAN9221 device (smsc911x driver). This patch
> adds a shift parameter in platform_data. The feature must be
> enabled at configuration time, because shifting by a pdata
> parameter makes access slower in those devices where no shift is
> needed (I tested one, it was 20% slower).
>
> If the platform data requests shifted access but the feature is
> unavailable, the probe method complains to the console. Board
> config files should set the configuration option when needed.
>
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Implement this at run time, keying off of a boolean or similar
in the platform data.
Implement a set of ops, one to do a PIO read one to do a PIO write,
and choose the set of ops appropriate for the device depending upon
the setting found in the platform device.
next prev parent reply other threads:[~2011-03-25 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 21:27 [PATCH] net: allow shifted address in smsc911x mathieu.poirier
2011-03-25 21:31 ` David Miller [this message]
2011-03-29 21:17 ` Mathieu Poirier
2011-03-25 21:46 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110325.143103.25112180.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=patches@linaro.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).