From: David Miller <davem@davemloft.net>
To: amit.salecha@qlogic.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
ameen.rahman@qlogic.com, rajesh.borundia@qlogic.com
Subject: Re: [PATCH] netxen: fix LRO disable warning
Date: Sun, 27 Mar 2011 18:08:18 -0700 (PDT) [thread overview]
Message-ID: <20110327.180818.39174806.davem@davemloft.net> (raw)
In-Reply-To: <99737F4847ED0A48AECC9F4A1974A4B80FD10E8439@MNEXMB2.qlogic.org>
From: Amit Salecha <amit.salecha@qlogic.com>
Date: Mon, 21 Mar 2011 06:13:02 -0500
>> Le lundi 21 mars 2011 à 03:37 -0700, Amit Kumar Salecha a écrit :
>> > netxen_nic_set_flags() rejects data if other flag than ETH_FLAG_LRO
>> is set.
>> > Driver also supports NETIF_F_HW_VLAN_TX.
>> > Now compare data with ethtool_op_get_flags(), to get all supported
>> features.
>> >
>> > Reported-by: Jesper Dangaard Brouer <jdb@comx.dk>
>> > Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
>> > Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
>> > ---
>>
>> Hmm, it would be really nice you provide more information for stable
>> teams.
>>
>> If I am not mistaken, bug was introduced in 2.6.36 ?
>>
> No, It was introduced in 2.6.37, when ETH_FLAG_TXVLAN and ETH_FLAG_RXVLAN introduced.
> Yes it should also make into 2.6.37.4 stable kernel.
Applied, but 2.6.37.x maintainence has ceased so there is no point
worrying about this patch for that stable branch any longer.
next prev parent reply other threads:[~2011-03-28 1:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 10:37 [PATCH] netxen: fix LRO disable warning Amit Kumar Salecha
2011-03-21 10:47 ` Eric Dumazet
2011-03-21 11:13 ` Amit Salecha
2011-03-28 1:08 ` David Miller [this message]
2011-03-28 5:33 ` Amit Salecha
2011-03-28 5:17 ` Stanislaw Gruszka
2011-03-28 6:31 ` David Miller
2011-03-28 6:29 ` David Miller
2011-04-03 19:05 ` Netxen packet loss with VLANs and LRO (was: [PATCH] netxen: fix LRO disable warning) Marc Haber
2011-04-05 5:38 ` Amit Salecha
2011-04-05 10:38 ` Michał Mirosław
2011-04-05 12:41 ` Marc Haber
2011-04-05 13:15 ` Amit Salecha
2011-04-05 15:18 ` Marc Haber
2011-04-05 15:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110327.180818.39174806.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).