From: David Miller <davem@davemloft.net>
To: xmb836@motorola.com
Cc: netdev@vger.kernel.org, a20612@motorola.com, jxchang@motorola.com
Subject: Re: [PATCH] usbnet: fix memory leak in usbnet_disconnect()
Date: Sun, 27 Mar 2011 18:11:07 -0700 (PDT) [thread overview]
Message-ID: <20110327.181107.115927388.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTintuq7z45e-Cr8Ma5_Bm+UtnO+Gsysn6A3kv+CZ@mail.gmail.com>
From: DMITRIY GRUZMAN <xmb836@motorola.com>
Date: Mon, 21 Mar 2011 16:49:50 -0500
> usb_probe() allocates memory for transfer buffer and urb and this
> memory was not properly released in usbnet_disconnect(). The issue
> was found and the fix was recommended by Fu-Lei Tian and Jun-Xiao
> Chang.
>
> Signed-off-by: Dmitriy Gruzman <xmb836@motorola.com>
Your email client corrupted your patch, among other things:
> @@ -210,6 +210,7 @@ static int init_status (struct usbnet *dev, struct
> usb_interface *intf)
it chopped up long lines.
Please fix this up, test your setup by emailing the patch to yourself
and trying to apply what you receive, then try submitting it here
freshly again.
Thanks.
next prev parent reply other threads:[~2011-03-28 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 21:49 [PATCH] usbnet: fix memory leak in usbnet_disconnect() DMITRIY GRUZMAN
2011-03-28 1:11 ` David Miller [this message]
2011-03-28 20:01 ` Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110327.181107.115927388.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a20612@motorola.com \
--cc=jxchang@motorola.com \
--cc=netdev@vger.kernel.org \
--cc=xmb836@motorola.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).