From: David Miller <davem@davemloft.net>
To: kurt.van.dijck@eia.be
Cc: socketcan@hartkopp.net, netdev@vger.kernel.org
Subject: Re: [PATCH] can: make struct proto const
Date: Sun, 27 Mar 2011 18:14:14 -0700 (PDT) [thread overview]
Message-ID: <20110327.181414.260098631.davem@davemloft.net> (raw)
In-Reply-To: <20110322190038.GA286@e-circ.dyndns.org>
From: Kurt Van Dijck <kurt.van.dijck@eia.be>
Date: Tue, 22 Mar 2011 20:00:38 +0100
> On Tue, Mar 22, 2011 at 07:27:25PM +0100, Oliver Hartkopp wrote:
>> can_ioctl is the only reason for struct proto to be non-const.
>> script/check-patch.pl suggests struct proto be const.
>>
>> Setting the reference to the common can_ioctl() in all CAN protocols directly
>> removes the need to make the struct proto writable in af_can.c
>>
>> Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
>> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
>>
> Good idea to take this apart from my J1939 series.
Applied, thanks.
prev parent reply other threads:[~2011-03-28 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 18:27 [PATCH] can: make struct proto const Oliver Hartkopp
2011-03-22 19:00 ` Kurt Van Dijck
2011-03-28 1:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110327.181414.260098631.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kurt.van.dijck@eia.be \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).