From: David Miller <davem@davemloft.net>
To: gallatin@myri.com
Cc: sgruszka@redhat.com, netdev@vger.kernel.org, brice@myri.com,
shemminger@vyatta.com, dhowells@redhat.com,
bhutchings@solarflare.com
Subject: Re: [PATCH] myri10ge: small rx_done refactoring
Date: Sun, 27 Mar 2011 18:35:14 -0700 (PDT) [thread overview]
Message-ID: <20110327.183514.35025158.davem@davemloft.net> (raw)
In-Reply-To: <4D8C92B9.1010109@myri.com>
From: Andrew Gallatin <gallatin@myri.com>
Date: Fri, 25 Mar 2011 09:03:53 -0400
> On 03/25/11 07:21, Stanislaw Gruszka wrote:
>> Avoid theoretical race condition regarding accessing dev->features
>> NETIF_F_LRO flag, which is illustrated below.
>>
...
>>
>> On the way reduce myri10ge_rx_done() number of arguments and calls by
>> moving mgp->small_bytes check into that function. That reduce code
>> size
>>
...
>>
>> on my i686 system, what should also make myri10ge_clean_rx_done()
>> being faster.
>>
>> Signed-off-by: Stanislaw Gruszka<sgruszka@redhat.com>
>
> Thank you very much!
>
> Acked by: Andrew Gallatin <gallatin@myri.com>
Applied, thanks everyone.
prev parent reply other threads:[~2011-03-28 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 11:21 [PATCH] myri10ge: small rx_done refactoring Stanislaw Gruszka
2011-03-25 13:03 ` Andrew Gallatin
2011-03-28 1:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110327.183514.35025158.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=brice@myri.com \
--cc=dhowells@redhat.com \
--cc=gallatin@myri.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).