* [PATCH] net: use CHECKSUM_NONE instead of magic number
@ 2011-03-26 15:10 Cesar Eduardo Barros
2011-03-28 1:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cesar Eduardo Barros @ 2011-03-26 15:10 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Alexey Kuznetsov, Pekka Savola (ipv6),
James Morris, Hideaki YOSHIFUJI, Patrick McHardy, Eric Dumazet,
Tristram Ha, linux-kernel, Cesar Eduardo Barros
Two places in the kernel were doing skb->ip_summed = 0.
Change both to skb->ip_summed = CHECKSUM_NONE, which is more readable.
Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
---
drivers/net/ksz884x.c | 2 +-
net/ipv6/ip6mr.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
index 540a8dc..7f7d570 100644
--- a/drivers/net/ksz884x.c
+++ b/drivers/net/ksz884x.c
@@ -4898,7 +4898,7 @@ static netdev_tx_t netdev_tx(struct sk_buff *skb, struct net_device *dev)
goto unlock;
}
skb_copy_and_csum_dev(org_skb, skb->data);
- org_skb->ip_summed = 0;
+ org_skb->ip_summed = CHECKSUM_NONE;
skb->len = org_skb->len;
copy_old_skb(org_skb, skb);
}
diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index 7ff0343..29e4859 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/ip6mr.c
@@ -663,7 +663,7 @@ static int pim6_rcv(struct sk_buff *skb)
skb_pull(skb, (u8 *)encap - skb->data);
skb_reset_network_header(skb);
skb->protocol = htons(ETH_P_IPV6);
- skb->ip_summed = 0;
+ skb->ip_summed = CHECKSUM_NONE;
skb->pkt_type = PACKET_HOST;
skb_tunnel_rx(skb, reg_dev);
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: use CHECKSUM_NONE instead of magic number
2011-03-26 15:10 [PATCH] net: use CHECKSUM_NONE instead of magic number Cesar Eduardo Barros
@ 2011-03-28 1:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-03-28 1:37 UTC (permalink / raw)
To: cesarb
Cc: netdev, kuznet, pekkas, jmorris, yoshfuji, kaber, eric.dumazet,
Tristram.Ha, linux-kernel
From: Cesar Eduardo Barros <cesarb@cesarb.net>
Date: Sat, 26 Mar 2011 12:10:30 -0300
> Two places in the kernel were doing skb->ip_summed = 0.
>
> Change both to skb->ip_summed = CHECKSUM_NONE, which is more readable.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-28 1:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-26 15:10 [PATCH] net: use CHECKSUM_NONE instead of magic number Cesar Eduardo Barros
2011-03-28 1:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).