* [PATCH 1/2] solos-pci: Debugging fixes
@ 2011-03-28 2:02 Philip Prindeville
2011-03-28 4:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Philip Prindeville @ 2011-03-28 2:02 UTC (permalink / raw)
To: Netdev
Use VPI.VCI notation consistently.
Signed-off-by: Philip Prindeville<philipp@redfish-solutions.com>
---
drivers/atm/solos-pci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 25ef1a4..2c4146a 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -710,8 +710,8 @@ void solos_bh(unsigned long card_arg)
le16_to_cpu(header->vci));
if (!vcc) {
if (net_ratelimit())
- dev_warn(&card->dev->dev, "Received packet for unknown VCI.VPI %d.%d on port %d\n",
- le16_to_cpu(header->vci), le16_to_cpu(header->vpi),
+ dev_warn(&card->dev->dev, "Received packet for unknown VPI.VCI %d.%d on port %d\n",
+ le16_to_cpu(header->vpi), le16_to_cpu(header->vci),
port);
continue;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] solos-pci: Debugging fixes
2011-03-28 2:02 [PATCH 1/2] solos-pci: Debugging fixes Philip Prindeville
@ 2011-03-28 4:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-03-28 4:08 UTC (permalink / raw)
To: philipp_subx; +Cc: netdev
From: Philip Prindeville <philipp_subx@redfish-solutions.com>
Date: Sun, 27 Mar 2011 19:02:54 -0700
> Use VPI.VCI notation consistently.
>
> Signed-off-by: Philip Prindeville<philipp@redfish-solutions.com>
The Subject line is where you describe what the change does.
If you use the same exact subject line in a set of changes,
over and over again, people have no idea what distinguishes
one of the change from the others.
Please fix up your commit messages so that the Subject lines
are more informative.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-28 4:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 2:02 [PATCH 1/2] solos-pci: Debugging fixes Philip Prindeville
2011-03-28 4:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).