From: Dan Carpenter <error27@gmail.com>
To: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: netdev@vger.kernel.org
Subject: smatch stuff: use after free bug
Date: Mon, 28 Mar 2011 13:31:40 +0300 [thread overview]
Message-ID: <20110328103140.GJ1885@bicker> (raw)
Smatch complains about this. It's not obvious to me how to fix it. The
bug was introduced in b12d93d63 "mlx4: Add support for promiscuous mode
in the new steering model.".
drivers/net/mlx4/mcg.c +530
remove_promisc_qp(89) warn: 'pqp' was already freed.
526 out_mailbox:
527 mlx4_free_cmd_mailbox(dev, mailbox);
528 out_list:
529 if (back_to_list)
530 list_add_tail(&pqp->list, &s_steer->promisc_qps[steer]);
^^^^^^^^^^
This list was deleted and pqp was freed at this point.
531 out_mutex:
532 mutex_unlock(&priv->mcg_table.mutex);
533 return err;
534 }
regards,
dan carpenter
next reply other threads:[~2011-03-28 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 10:31 Dan Carpenter [this message]
2011-03-28 12:34 ` smatch stuff: use after free bug Yevgeny Petrilin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328103140.GJ1885@bicker \
--to=error27@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox