From: Anton Blanchard <anton@samba.org>
To: divy@chelsio.com
Cc: netdev@vger.kernel.org
Subject: [PATCH] cxgb3: Apply interrupt coalescing settings to all queues
Date: Mon, 28 Mar 2011 13:50:41 +1100 [thread overview]
Message-ID: <20110328135041.57cec646@kryten> (raw)
While testing the performance of different receive interrupt
coalescing settings on a single stream TCP benchmark, I noticed two
very different results. With rx-usecs=50, most of the time a
connection would hit 8280 Mbps but once in a while it would hit
9330 Mbps.
It turns out we are only applying the interrupt coalescing settings
to the first queue and whenever the rx hash would direct us onto
that queue we ran faster.
With this patch applied and rx-usecs=50, I get 9330 Mbps
consistently.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: powerpc.git/drivers/net/cxgb3/cxgb3_main.c
===================================================================
--- powerpc.git.orig/drivers/net/cxgb3/cxgb3_main.c 2011-03-28 12:36:41.775206214 +1100
+++ powerpc.git/drivers/net/cxgb3/cxgb3_main.c 2011-03-28 12:41:29.892189120 +1100
@@ -1983,14 +1983,20 @@ static int set_coalesce(struct net_devic
{
struct port_info *pi = netdev_priv(dev);
struct adapter *adapter = pi->adapter;
- struct qset_params *qsp = &adapter->params.sge.qset[0];
- struct sge_qset *qs = &adapter->sge.qs[0];
+ struct qset_params *qsp;
+ struct sge_qset *qs;
+ int i;
if (c->rx_coalesce_usecs * 10 > M_NEWTIMER)
return -EINVAL;
- qsp->coalesce_usecs = c->rx_coalesce_usecs;
- t3_update_qset_coalesce(qs, qsp);
+ for (i = 0; i < pi->nqsets; i++) {
+ qsp = &adapter->params.sge.qset[i];
+ qs = &adapter->sge.qs[i];
+ qsp->coalesce_usecs = c->rx_coalesce_usecs;
+ t3_update_qset_coalesce(qs, qsp);
+ }
+
return 0;
}
next reply other threads:[~2011-03-28 2:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 2:50 Anton Blanchard [this message]
2011-03-28 17:41 ` [PATCH] cxgb3: Apply interrupt coalescing settings to all queues Divy Le Ray
2011-03-29 5:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328135041.57cec646@kryten \
--to=anton@samba.org \
--cc=divy@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).