From: David Miller <davem@davemloft.net>
To: linus.luessing@web.de
Cc: bridge@lists.linux-foundation.org,
shemminger@linux-foundation.org, yoshfuji@linux-ipv6.org,
herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: mcast snooping, fix length check of snooped MLDv1/2
Date: Wed, 30 Mar 2011 02:30:01 -0700 (PDT) [thread overview]
Message-ID: <20110330.023001.13743450.davem@davemloft.net> (raw)
In-Reply-To: <1301207244-10428-3-git-send-email-linus.luessing@web.de>
From: Linus Lüssing <linus.luessing@web.de>
Date: Sun, 27 Mar 2011 08:27:24 +0200
> "len = ntohs(ip6h->payload_len)" does not include the length of the ipv6
> header itself, which the rest of this function assumes, though.
>
> This leads to a length check less restrictive as it should be in the
> following line for one thing. For another, it very likely leads to an
> integer underrun when substracting the offset and therefore to a very
> high new value of 'len' due to its unsignedness. This will ultimately
> lead to the pskb_trim_rcsum() practically never being called, even in
> the cases where it should.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Applied.
prev parent reply other threads:[~2011-03-30 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-27 3:44 Checksumming bug in bridge multicast snooping for IPv6? Linus Lüssing
2011-03-27 6:27 ` bridge: mcast snooping, fixes for IPv6 MLDv1/2 parsing Linus Lüssing
2011-03-27 6:27 ` [PATCH] bridge: mcast snooping, fix IPv6 MLD checksum calculation Linus Lüssing
2011-03-27 6:37 ` Herbert Xu
2011-03-27 7:06 ` Linus Lüssing
2011-03-27 7:52 ` Herbert Xu
2011-03-30 9:29 ` David Miller
2011-03-27 6:27 ` [PATCH] bridge: mcast snooping, fix length check of snooped MLDv1/2 Linus Lüssing
2011-03-30 9:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330.023001.13743450.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linus.luessing@web.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).