From: David Miller <davem@davemloft.net>
To: mkl@pengutronix.de
Cc: Netdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] phylib: phy_attach_direct: phy_init_hw can fail, add cleanup
Date: Wed, 30 Mar 2011 02:31:50 -0700 (PDT) [thread overview]
Message-ID: <20110330.023150.58429467.davem@davemloft.net> (raw)
In-Reply-To: <1301360048-14095-1-git-send-email-mkl@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Tue, 29 Mar 2011 02:54:08 +0200
> The function phy_attach_direct attaches the phy and calls phy_init_hw.
> phy_init_hw can fail, but the phy is still marked as attached. Successive
> calls to phy_attach_direct will fail because the phy is busy.
...
> This patch adds phy_detach to clean up if phy_init_hw fails.
>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Applied, thank you.
prev parent reply other threads:[~2011-03-30 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 0:54 [PATCH] phylib: phy_attach_direct: phy_init_hw can fail, add cleanup Marc Kleine-Budde
2011-03-30 9:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330.023150.58429467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Netdev@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox