From: David Miller <davem@davemloft.net>
To: daniel@free.fr
Cc: ebiederm@xmission.com, eric.dumazet@gmail.com, kaber@trash.net,
nightnord@gmail.com, netdev@vger.kernel.org
Subject: Re: [V4] dev : fix mtu check when TSO is enabled
Date: Wed, 30 Mar 2011 02:42:31 -0700 (PDT) [thread overview]
Message-ID: <20110330.024231.57465584.davem@davemloft.net> (raw)
In-Reply-To: <1301478035-324-1-git-send-email-daniel@free.fr>
From: Daniel Lezcano <daniel@free.fr>
Date: Wed, 30 Mar 2011 11:40:35 +0200
> From: Daniel Lezcano <daniel.lezcano@free.fr>
>
> In case the device where is coming from the packet has TSO enabled,
> we should not check the mtu size value as this one could be bigger
> than the expected value.
>
> This is the case for the macvlan driver when the lower device has
> TSO enabled. The macvlan inherit this feature and forward the packets
> without fragmenting them. Then the packets go through dev_forward_skb
> and are dropped. This patch fix this by checking TSO is not enabled
> when we want to check the mtu size.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr>
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Applied.
prev parent reply other threads:[~2011-03-30 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 9:40 [V4] dev : fix mtu check when TSO is enabled Daniel Lezcano
2011-03-30 9:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330.024231.57465584.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@free.fr \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=nightnord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox