* [PATCH 1/2] Use VPI.VCI notation uniformly.
@ 2011-03-30 22:56 Philip Prindeville
2011-03-30 23:03 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Philip Prindeville @ 2011-03-30 22:56 UTC (permalink / raw)
To: netdev
From: Philip A. Prindeville <philipp@redfish-solutions.com>
Use VPI.VCI notation consistently throughout the module. This is the
one remaining place where the VCI is used before the VPI in any output.
Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
---
drivers/atm/solos-pci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 25ef1a4..2c4146a 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -710,8 +710,8 @@ void solos_bh(unsigned long card_arg)
le16_to_cpu(header->vci));
if (!vcc) {
if (net_ratelimit())
- dev_warn(&card->dev->dev, "Received packet for unknown VCI.VPI %d.%d on port %d\n",
- le16_to_cpu(header->vci), le16_to_cpu(header->vpi),
+ dev_warn(&card->dev->dev, "Received packet for unknown VPI.VCI %d.%d on port %d\n",
+ le16_to_cpu(header->vpi), le16_to_cpu(header->vci),
port);
continue;
}
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] Use VPI.VCI notation uniformly.
2011-03-30 22:56 [PATCH 1/2] Use VPI.VCI notation uniformly Philip Prindeville
@ 2011-03-30 23:03 ` David Miller
2011-03-30 23:17 ` Philip Prindeville
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2011-03-30 23:03 UTC (permalink / raw)
To: philipp_subx; +Cc: netdev
From: Philip Prindeville <philipp_subx@redfish-solutions.com>
Date: Wed, 30 Mar 2011 16:56:27 -0600
> From: Philip A. Prindeville <philipp@redfish-solutions.com>
>
> Use VPI.VCI notation consistently throughout the module. This is the
> one remaining place where the VCI is used before the VPI in any output.
>
> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
> ---
> drivers/atm/solos-pci.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Why do your subject lines not have an appropriate prefix?
How will someone scanning the commit header lines in the tree know
that this is a change to the solos-pci driver unless you prefix
them with "solos-pci: " or similar?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] Use VPI.VCI notation uniformly.
2011-03-30 23:03 ` David Miller
@ 2011-03-30 23:17 ` Philip Prindeville
0 siblings, 0 replies; 3+ messages in thread
From: Philip Prindeville @ 2011-03-30 23:17 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On 3/30/11 5:03 PM, David Miller wrote:
> From: Philip Prindeville <philipp_subx@redfish-solutions.com>
> Date: Wed, 30 Mar 2011 16:56:27 -0600
>
>> From: Philip A. Prindeville <philipp@redfish-solutions.com>
>>
>> Use VPI.VCI notation consistently throughout the module. This is the
>> one remaining place where the VCI is used before the VPI in any output.
>>
>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
>> ---
>> drivers/atm/solos-pci.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
> Why do your subject lines not have an appropriate prefix?
>
> How will someone scanning the commit header lines in the tree know
> that this is a change to the solos-pci driver unless you prefix
> them with "solos-pci: " or similar?
It was an oversight. Want me to resubmit?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-30 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-30 22:56 [PATCH 1/2] Use VPI.VCI notation uniformly Philip Prindeville
2011-03-30 23:03 ` David Miller
2011-03-30 23:17 ` Philip Prindeville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox