From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: steve.glendinning@smsc.com, jtp.park@samsung.com, netdev@vger.kernel.org
Subject: Re: [PATCH] smsc911x: Use pr_fmt, netdev_<level>, and netif_<level>
Date: Wed, 30 Mar 2011 21:43:07 -0700 (PDT) [thread overview]
Message-ID: <20110330.214307.63030538.davem@davemloft.net> (raw)
In-Reply-To: <1301098883.4132.23.camel@Joe-Laptop>
From: Joe Perches <joe@perches.com>
Date: Fri, 25 Mar 2011 17:21:22 -0700
> Use the more common/verbose logging styles.
>
> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Remove smsc911x prefixes from format strings.
> Rename SMSC_WARNING to SMSC_WARN.
> Remove DPRINTK macro.
> Use netif_<level> in SMSC_<level> macros.
> Convert NETIF_MSG_<foo> uses to lower case.
> Add no_printk verification in non-debug uses.
> Add pdata to SMSC_<level> uses to avoid hidden variable uses.
> Convert printks to netdev_<level> as appropriate.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
prev parent reply other threads:[~2011-03-31 4:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 0:21 [PATCH] smsc911x: Use pr_fmt, netdev_<level>, and netif_<level> Joe Perches
2011-03-31 4:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330.214307.63030538.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=jtp.park@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).