From: Domenico Andreoli <cavokz@gmail.com>
To: netdev@vger.kernel.org
Subject: usage of netdev_boot_setup_check() in modern NIC driver
Date: Thu, 31 Mar 2011 18:41:17 +0200 [thread overview]
Message-ID: <20110331164117.GA14852@dandreoli.com> (raw)
Hi all,
I'm working on the cs89x0 driver to make it a modern dual ISA/platform
driver (it is used on some non-ISA dev boards, like my QQ2440). Funny
game that could end in nothing except some new learnings for me.
It uses the netdev_boot_setup_check() function to get the configuration
from cmdline. The only other modern ISA driver (isa_(un)register_driver)
which uses it is the 3c509, which seems to invoke and immediately
overwrite part of the values just got.
Since nowdays module params can be set on the cmdline as well, may I
simply dump netdev_boot_setup_check()? It smells of legacy stuff.
In case of multiple NICs, which is the suggested way to pass the
different parameters (irq, iomem, etc) to every card?
Do you agree that such parameters have sense only on the ISA side of
the driver?
Regards,
Domenico
-----[ Domenico Andreoli, aka cavok
--[ http://www.dandreoli.com/gpgkey.asc
---[ 3A0F 2F80 F79C 678A 8936 4FEE 0677 9033 A20E BC50
reply other threads:[~2011-03-31 16:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331164117.GA14852@dandreoli.com \
--to=cavokz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).