* [PATCH 1/9 net-next-2.6] qlcnic: make PCI info available in all modes
@ 2011-03-30 20:21 Anirban Chakraborty
2011-03-31 4:40 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Anirban Chakraborty @ 2011-03-30 20:21 UTC (permalink / raw)
To: David Miller, netdev@vger.kernel.org; +Cc: Dept_NX_Linux_NIC_Driver
From: Sony Chacko <sony.chacko@qlogic.com>
Before this fix, PCI info was available only when multiple NIC functions were
present on a port.
Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
---
drivers/net/qlcnic/qlcnic_main.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index cd88c7e..d230fdd 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -3954,14 +3954,14 @@ qlcnic_create_diag_entries(struct qlcnic_adapter *adapter)
dev_info(dev, "failed to create crb sysfs entry\n");
if (device_create_bin_file(dev, &bin_attr_mem))
dev_info(dev, "failed to create mem sysfs entry\n");
+ if (device_create_bin_file(dev, &bin_attr_pci_config))
+ dev_info(dev, "failed to create pci config sysfs entry");
if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
return;
if (device_create_bin_file(dev, &bin_attr_esw_config))
dev_info(dev, "failed to create esw config sysfs entry");
if (adapter->op_mode != QLCNIC_MGMT_FUNC)
return;
- if (device_create_bin_file(dev, &bin_attr_pci_config))
- dev_info(dev, "failed to create pci config sysfs entry");
if (device_create_bin_file(dev, &bin_attr_npar_config))
dev_info(dev, "failed to create npar config sysfs entry");
if (device_create_bin_file(dev, &bin_attr_pm_config))
@@ -3982,12 +3982,12 @@ qlcnic_remove_diag_entries(struct qlcnic_adapter *adapter)
device_remove_file(dev, &dev_attr_diag_mode);
device_remove_bin_file(dev, &bin_attr_crb);
device_remove_bin_file(dev, &bin_attr_mem);
+ device_remove_bin_file(dev, &bin_attr_pci_config);
if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
return;
device_remove_bin_file(dev, &bin_attr_esw_config);
if (adapter->op_mode != QLCNIC_MGMT_FUNC)
return;
- device_remove_bin_file(dev, &bin_attr_pci_config);
device_remove_bin_file(dev, &bin_attr_npar_config);
device_remove_bin_file(dev, &bin_attr_pm_config);
device_remove_bin_file(dev, &bin_attr_esw_stats);
--
1.6.5.2
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/9 net-next-2.6] qlcnic: make PCI info available in all modes
2011-03-30 20:21 [PATCH 1/9 net-next-2.6] qlcnic: make " Anirban Chakraborty
@ 2011-03-31 4:40 ` David Miller
2011-03-31 17:04 ` Anirban Chakraborty
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2011-03-31 4:40 UTC (permalink / raw)
To: anirban.chakraborty; +Cc: netdev, Dept_NX_Linux_NIC_Driver
From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Date: Wed, 30 Mar 2011 13:21:36 -0700
> From: Sony Chacko <sony.chacko@qlogic.com>
>
> Before this fix, PCI info was available only when multiple NIC functions were
> present on a port.
>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Your email client has mangled all of these patches, turning tab characters
into spaces.
Given the number of patches that come in for the qlcnic driver, you guys
have to do better than this.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/9 net-next-2.6] qlcnic: make PCI info available in all modes
2011-03-31 4:40 ` David Miller
@ 2011-03-31 17:04 ` Anirban Chakraborty
0 siblings, 0 replies; 10+ messages in thread
From: Anirban Chakraborty @ 2011-03-31 17:04 UTC (permalink / raw)
To: David Miller; +Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver
On Mar 30, 2011, at 9:40 PM, David Miller wrote:
> From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
> Date: Wed, 30 Mar 2011 13:21:36 -0700
>
>> From: Sony Chacko <sony.chacko@qlogic.com>
>>
>> Before this fix, PCI info was available only when multiple NIC functions were
>> present on a port.
>>
>> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
>> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
>
> Your email client has mangled all of these patches, turning tab characters
> into spaces.
>
> Given the number of patches that come in for the qlcnic driver, you guys
> have to do better than this.
Sorry about that. I use pine to send patches, not sure how it messed it up. I will resend it.
Thanks.
-Anirban
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes
@ 2011-04-01 22:56 Anirban Chakraborty
2011-04-02 0:08 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Anirban Chakraborty @ 2011-04-01 22:56 UTC (permalink / raw)
To: David Miller
Cc: netdev, Dept_NX_Linux_NIC_Driver, Sony Chacko,
Anirban Chakraborty
From: Sony Chacko <sony.chacko@qlogic.com>
Before this fix, PCI info was available only when multiple NIC functions
are present on the same port.
Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
---
drivers/net/qlcnic/qlcnic_main.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index cd88c7e..d230fdd 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -3954,14 +3954,14 @@ qlcnic_create_diag_entries(struct qlcnic_adapter *adapter)
dev_info(dev, "failed to create crb sysfs entry\n");
if (device_create_bin_file(dev, &bin_attr_mem))
dev_info(dev, "failed to create mem sysfs entry\n");
+ if (device_create_bin_file(dev, &bin_attr_pci_config))
+ dev_info(dev, "failed to create pci config sysfs entry");
if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
return;
if (device_create_bin_file(dev, &bin_attr_esw_config))
dev_info(dev, "failed to create esw config sysfs entry");
if (adapter->op_mode != QLCNIC_MGMT_FUNC)
return;
- if (device_create_bin_file(dev, &bin_attr_pci_config))
- dev_info(dev, "failed to create pci config sysfs entry");
if (device_create_bin_file(dev, &bin_attr_npar_config))
dev_info(dev, "failed to create npar config sysfs entry");
if (device_create_bin_file(dev, &bin_attr_pm_config))
@@ -3982,12 +3982,12 @@ qlcnic_remove_diag_entries(struct qlcnic_adapter *adapter)
device_remove_file(dev, &dev_attr_diag_mode);
device_remove_bin_file(dev, &bin_attr_crb);
device_remove_bin_file(dev, &bin_attr_mem);
+ device_remove_bin_file(dev, &bin_attr_pci_config);
if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
return;
device_remove_bin_file(dev, &bin_attr_esw_config);
if (adapter->op_mode != QLCNIC_MGMT_FUNC)
return;
- device_remove_bin_file(dev, &bin_attr_pci_config);
device_remove_bin_file(dev, &bin_attr_npar_config);
device_remove_bin_file(dev, &bin_attr_pm_config);
device_remove_bin_file(dev, &bin_attr_esw_stats);
--
1.7.1
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes
@ 2011-04-02 0:07 anirban.chakraborty
0 siblings, 0 replies; 10+ messages in thread
From: anirban.chakraborty @ 2011-04-02 0:07 UTC (permalink / raw)
To: netdev; +Cc: davem, Dept_NX_Linux_NIC_driver, Sony Chacko
From: Sony Chacko <sony.chacko@qlogic.com>
Before this fix, PCI info was available only when multiple NIC functions
are present on the same port.
Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
---
drivers/net/qlcnic/qlcnic_main.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index cd88c7e..d230fdd 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -3954,14 +3954,14 @@ qlcnic_create_diag_entries(struct qlcnic_adapter *adapter)
dev_info(dev, "failed to create crb sysfs entry\n");
if (device_create_bin_file(dev, &bin_attr_mem))
dev_info(dev, "failed to create mem sysfs entry\n");
+ if (device_create_bin_file(dev, &bin_attr_pci_config))
+ dev_info(dev, "failed to create pci config sysfs entry");
if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
return;
if (device_create_bin_file(dev, &bin_attr_esw_config))
dev_info(dev, "failed to create esw config sysfs entry");
if (adapter->op_mode != QLCNIC_MGMT_FUNC)
return;
- if (device_create_bin_file(dev, &bin_attr_pci_config))
- dev_info(dev, "failed to create pci config sysfs entry");
if (device_create_bin_file(dev, &bin_attr_npar_config))
dev_info(dev, "failed to create npar config sysfs entry");
if (device_create_bin_file(dev, &bin_attr_pm_config))
@@ -3982,12 +3982,12 @@ qlcnic_remove_diag_entries(struct qlcnic_adapter *adapter)
device_remove_file(dev, &dev_attr_diag_mode);
device_remove_bin_file(dev, &bin_attr_crb);
device_remove_bin_file(dev, &bin_attr_mem);
+ device_remove_bin_file(dev, &bin_attr_pci_config);
if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
return;
device_remove_bin_file(dev, &bin_attr_esw_config);
if (adapter->op_mode != QLCNIC_MGMT_FUNC)
return;
- device_remove_bin_file(dev, &bin_attr_pci_config);
device_remove_bin_file(dev, &bin_attr_npar_config);
device_remove_bin_file(dev, &bin_attr_pm_config);
device_remove_bin_file(dev, &bin_attr_esw_stats);
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes
2011-04-01 22:56 [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes Anirban Chakraborty
@ 2011-04-02 0:08 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2011-04-02 0:08 UTC (permalink / raw)
To: anirban.chakraborty; +Cc: davem, netdev, Dept_NX_Linux_NIC_Driver, sony.chacko
Well, where is the rest of the patch set?
I only received #1, you have to resend the whole set.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes
@ 2011-04-02 0:27 anirban.chakraborty
2011-04-02 1:18 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: anirban.chakraborty @ 2011-04-02 0:27 UTC (permalink / raw)
To: davem; +Cc: netdev, amit.salecha, ameen.rahman, Sony Chacko
From: Sony Chacko <sony.chacko@qlogic.com>
Before this fix, PCI info was available only when multiple NIC functions
are present on the same port.
Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
---
drivers/net/qlcnic/qlcnic_main.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index cd88c7e..d230fdd 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -3954,14 +3954,14 @@ qlcnic_create_diag_entries(struct qlcnic_adapter *adapter)
dev_info(dev, "failed to create crb sysfs entry\n");
if (device_create_bin_file(dev, &bin_attr_mem))
dev_info(dev, "failed to create mem sysfs entry\n");
+ if (device_create_bin_file(dev, &bin_attr_pci_config))
+ dev_info(dev, "failed to create pci config sysfs entry");
if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
return;
if (device_create_bin_file(dev, &bin_attr_esw_config))
dev_info(dev, "failed to create esw config sysfs entry");
if (adapter->op_mode != QLCNIC_MGMT_FUNC)
return;
- if (device_create_bin_file(dev, &bin_attr_pci_config))
- dev_info(dev, "failed to create pci config sysfs entry");
if (device_create_bin_file(dev, &bin_attr_npar_config))
dev_info(dev, "failed to create npar config sysfs entry");
if (device_create_bin_file(dev, &bin_attr_pm_config))
@@ -3982,12 +3982,12 @@ qlcnic_remove_diag_entries(struct qlcnic_adapter *adapter)
device_remove_file(dev, &dev_attr_diag_mode);
device_remove_bin_file(dev, &bin_attr_crb);
device_remove_bin_file(dev, &bin_attr_mem);
+ device_remove_bin_file(dev, &bin_attr_pci_config);
if (!(adapter->flags & QLCNIC_ESWITCH_ENABLED))
return;
device_remove_bin_file(dev, &bin_attr_esw_config);
if (adapter->op_mode != QLCNIC_MGMT_FUNC)
return;
- device_remove_bin_file(dev, &bin_attr_pci_config);
device_remove_bin_file(dev, &bin_attr_npar_config);
device_remove_bin_file(dev, &bin_attr_pm_config);
device_remove_bin_file(dev, &bin_attr_esw_stats);
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes
2011-04-02 0:27 anirban.chakraborty
@ 2011-04-02 1:18 ` David Miller
2011-04-02 1:20 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2011-04-02 1:18 UTC (permalink / raw)
To: anirban.chakraborty
Cc: davem, netdev, amit.salecha, ameen.rahman, sony.chacko
davemloft.com is not my email domain, it's davemloft.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes
2011-04-02 1:18 ` David Miller
@ 2011-04-02 1:20 ` David Miller
2011-04-02 2:14 ` Anirban Chakraborty
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2011-04-02 1:20 UTC (permalink / raw)
To: anirban.chakraborty
Cc: davem, netdev, amit.salecha, ameen.rahman, sony.chacko
From: David Miller <davem@davemloft.net>
Date: Fri, 01 Apr 2011 18:18:13 -0700 (PDT)
>
> davemloft.com is not my email domain, it's davemloft.org
See, I can't even get it right, it's davemloft.net :-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes
2011-04-02 1:20 ` David Miller
@ 2011-04-02 2:14 ` Anirban Chakraborty
0 siblings, 0 replies; 10+ messages in thread
From: Anirban Chakraborty @ 2011-04-02 2:14 UTC (permalink / raw)
To: David Miller
Cc: netdev@vger.kernel.org, Amit Salecha, Ameen Rahman, Sony Chacko
On Apr 1, 2011, at 6:20 PM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Fri, 01 Apr 2011 18:18:13 -0700 (PDT)
>
>>
>> davemloft.com is not my email domain, it's davemloft.org
>
> See, I can't even get it right, it's davemloft.net :-)
It must be my influence! :-)
-Anirban
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-04-02 2:15 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-01 22:56 [PATCH 1/9 net-next-2.6] qlcnic: Make PCI info available in all modes Anirban Chakraborty
2011-04-02 0:08 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-04-02 0:27 anirban.chakraborty
2011-04-02 1:18 ` David Miller
2011-04-02 1:20 ` David Miller
2011-04-02 2:14 ` Anirban Chakraborty
2011-04-02 0:07 anirban.chakraborty
2011-03-30 20:21 [PATCH 1/9 net-next-2.6] qlcnic: make " Anirban Chakraborty
2011-03-31 4:40 ` David Miller
2011-03-31 17:04 ` Anirban Chakraborty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).