From: Jiri Bohac <jbohac@suse.cz>
To: Jiri Bohac <jbohac@suse.cz>
Cc: Ben Hutchings <ben@decadent.org.uk>,
Dan Rosenberg <drosenberg@vsecurity.com>,
ralf@linux-mips.org, davem@davemloft.net, netdev@vger.kernel.org,
security@kernel.org
Subject: Re: [PATCH v2] ROSE: prevent heap corruption with bad facilities
Date: Fri, 1 Apr 2011 14:29:38 +0200 [thread overview]
Message-ID: <20110401122938.GA2908@midget.suse.cz> (raw)
In-Reply-To: <20110331180225.GA6677@midget.suse.cz>
On Thu, Mar 31, 2011 at 08:02:25PM +0200, Jiri Bohac wrote:
> However, I wonder how much sense it makes to continue parsing the
> facilities if an unknown facility family appears. We don't know
> the length of its data, so we will interpret each 16 bytes a new
oops, typo:
s/16 bytes a new/16 bits as a new/
> facilities header, hopefully soon bailing out on *p != 0x00.
>
> In case of a long packet where every other byte is zero, the loop
> will spam the kernel log with the printk ... which could probably
> be classified as a security problem on its own. So how about the
> following instead? I have no idea if this breaks some rose
> specification, though.
--
Jiri Bohac <jbohac@suse.cz>
SUSE Labs, SUSE CZ
next prev parent reply other threads:[~2011-04-01 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-20 6:43 [PATCH v2] ROSE: prevent heap corruption with bad facilities Dan Rosenberg
2011-03-20 16:48 ` Ben Hutchings
2011-03-28 0:59 ` David Miller
2011-03-29 1:16 ` Ben Hutchings
2011-03-29 16:26 ` Ralf Baechle
2011-03-31 18:02 ` Jiri Bohac
2011-04-01 12:29 ` Jiri Bohac [this message]
2011-04-02 4:41 ` David Miller
2011-04-05 8:20 ` Jiri Bohac
2011-04-03 4:23 ` Ben Hutchings
2011-03-28 0:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110401122938.GA2908@midget.suse.cz \
--to=jbohac@suse.cz \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).