From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: Allow no-cache copy from user on transmit
Date: Mon, 04 Apr 2011 09:52:07 -0700 (PDT) [thread overview]
Message-ID: <20110404.095207.137846978.davem@davemloft.net> (raw)
In-Reply-To: <BANLkTik__2JSNHXf4JBDqQPgDmMgsT9Lug@mail.gmail.com>
From: Tom Herbert <therbert@google.com>
Date: Mon, 4 Apr 2011 08:10:08 -0700
>> So it's not correct to use ARCH_HAS_NOCACHE_UACCESS to conditionalize
>> things in the networking, just make sure linux/uaccess.h is included
>> at the call sites.
>>
> Why isn't this correct? Shouldn't it be okay if linux/uaccess.h
> (asm/uaccess.h) is always included where ARCH_HAS_NOCACHE_UACCESS is
> used?
I'm simply saying to get rid of the ARCH_HAS_NOCACHE_UACCESS ifdefs
you're adding to the networking code, since linux/uaccess.h makes sure
that a nop version of the nocache routines are available always.
If you ifdef the networking bits unnecessarily, those code paths
won't get build tested in the majority of my test builds, which are
on sparc64. So I want to avoid the conditionalized compilation if
at all possible.
next prev parent reply other threads:[~2011-04-04 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 4:56 [PATCH v3] net: Allow no-cache copy from user on transmit Tom Herbert
2011-04-04 5:03 ` David Miller
2011-04-04 5:23 ` David Miller
2011-04-04 15:10 ` Tom Herbert
2011-04-04 16:52 ` David Miller [this message]
2011-04-04 19:44 ` Tom Herbert
2011-04-04 20:05 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-03-31 5:04 Tom Herbert
2011-03-31 8:52 ` Michał Mirosław
2011-04-01 4:05 ` Tom Herbert
2011-04-02 3:49 ` David Miller
2011-04-02 3:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404.095207.137846978.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).