From: Jiri Pirko <jpirko@redhat.com>
To: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
Cc: Jesse Gross <jesse@kernel.org>,
netdev@vger.kernel.org, davem@davemloft.net,
shemminger@linux-foundation.org, kaber@trash.net,
fubar@us.ibm.com, eric.dumazet@gmail.com, andy@greyhouse.net,
xiaosuo@gmail.com, "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [patch net-next-2.6] net: vlan: make non-hw-accel rx path similar to hw-accel
Date: Tue, 5 Apr 2011 09:19:18 +0200 [thread overview]
Message-ID: <20110405071915.GA3640@psychotron.lan> (raw)
In-Reply-To: <4D9A2F4D.1000100@gmail.com>
Mon, Apr 04, 2011 at 10:51:25PM CEST, nicolas.2p.debian@gmail.com wrote:
>Le 04/04/2011 22:30, Jiri Pirko a écrit :
>>Mon, Apr 04, 2011 at 09:00:00PM CEST, nicolas.2p.debian@gmail.com wrote:
>>>Le 04/04/2011 09:14, Jiri Pirko a écrit :
><snip>
>>>So you want to move vlan_do_receive into an rx_handler, but want
>>>untagging to stay hard-coded at the beginning of __netif_receive_skb.
>>>I don't think I understand the rational behind that.
>>
>>vlan_hwaccel_do_receive/vlan_do_receive could be converted to
>>rx_handler, not untagging.
>
>Why do you consider untagging cannot be converted to rx_handler?
I already told you that the reason ot the patch is to unify hwaccel path
and nonhwaccel path. When you do untag in rx_handler, that's too late.
Paths would be still different.
prev parent reply other threads:[~2011-04-05 7:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 10:26 [patch net-next-2.6] net: vlan: make non-hw-accel rx path similar to hw-accel Jiri Pirko
2011-04-02 15:55 ` Stephen Hemminger
2011-04-02 18:27 ` Jiri Pirko
2011-04-03 9:27 ` Nicolas de Pesloüan
2011-04-03 13:22 ` Jiri Pirko
2011-04-03 15:23 ` Nicolas de Pesloüan
2011-04-03 20:38 ` Jesse Gross
2011-04-04 6:54 ` Nicolas de Pesloüan
2011-04-04 7:14 ` Jiri Pirko
2011-04-04 19:00 ` Nicolas de Pesloüan
2011-04-04 19:51 ` Eric W. Biederman
2011-04-04 20:29 ` Jiri Pirko
2011-04-04 20:47 ` Nicolas de Pesloüan
2011-04-04 20:50 ` Jesse Gross
2011-04-04 21:04 ` Nicolas de Pesloüan
2011-04-05 7:25 ` Jiri Pirko
2011-04-05 7:26 ` Jiri Pirko
2011-04-04 20:30 ` Jiri Pirko
2011-04-04 20:51 ` Nicolas de Pesloüan
2011-04-05 7:19 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405071915.GA3640@psychotron.lan \
--to=jpirko@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=jesse@kernel.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
--cc=shemminger@linux-foundation.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).