From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next-2.6] net: vlan: make non-hw-accel rx path similar to hw-accel Date: Tue, 5 Apr 2011 09:19:18 +0200 Message-ID: <20110405071915.GA3640@psychotron.lan> References: <1301739966-7604-1-git-send-email-jpirko@redhat.com> <4D989100.1090207@gmail.com> <4D996B30.3080408@gmail.com> <20110404071453.GA2791@psychotron.redhat.com> <4D9A1530.1010102@gmail.com> <20110404203002.GB3657@psychotron.redhat.com> <4D9A2F4D.1000100@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jesse Gross , netdev@vger.kernel.org, davem@davemloft.net, shemminger@linux-foundation.org, kaber@trash.net, fubar@us.ibm.com, eric.dumazet@gmail.com, andy@greyhouse.net, xiaosuo@gmail.com, "Eric W. Biederman" To: Nicolas de =?iso-8859-1?Q?Peslo=FCan?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19830 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920Ab1DEHUN (ORCPT ); Tue, 5 Apr 2011 03:20:13 -0400 Content-Disposition: inline In-Reply-To: <4D9A2F4D.1000100@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Apr 04, 2011 at 10:51:25PM CEST, nicolas.2p.debian@gmail.com wrote= : >Le 04/04/2011 22:30, Jiri Pirko a =E9crit : >>Mon, Apr 04, 2011 at 09:00:00PM CEST, nicolas.2p.debian@gmail.com wro= te: >>>Le 04/04/2011 09:14, Jiri Pirko a =E9crit : > >>>So you want to move vlan_do_receive into an rx_handler, but want >>>untagging to stay hard-coded at the beginning of __netif_receive_skb= =2E >>>I don't think I understand the rational behind that. >> >>vlan_hwaccel_do_receive/vlan_do_receive could be converted to >>rx_handler, not untagging. > >Why do you consider untagging cannot be converted to rx_handler? I already told you that the reason ot the patch is to unify hwaccel pat= h and nonhwaccel path. When you do untag in rx_handler, that's too late. Paths would be still different.