From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] Fix panic in ip6_pol_route Date: Wed, 06 Apr 2011 00:40:43 -0700 (PDT) Message-ID: <20110406.004043.193732725.davem@davemloft.net> References: <20110406064504.30691.36599.sendpatchset@krkumar2.in.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: krkumar2@in.ibm.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38139 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754364Ab1DFHlV (ORCPT ); Wed, 6 Apr 2011 03:41:21 -0400 In-Reply-To: <20110406064504.30691.36599.sendpatchset@krkumar2.in.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Krishna Kumar Date: Wed, 06 Apr 2011 12:15:04 +0530 > The fix is to not update ip6_null_entry for a vlan device. Please > review. This is just rediculious. Configuring a vlan on loopback is stupid. Having IFF_LOOPBACK be set on a loopback device is even more stupid. So fix one of those two things, otherwise we'll just add a million tests over time to this conditional.