netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: nhorman@tuxdriver.com, netdev@vger.kernel.org,
	kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, kaber@trash.net, therbert@google.com
Subject: Re: [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets
Date: Wed, 06 Apr 2011 11:27:12 -0700 (PDT)	[thread overview]
Message-ID: <20110406.112712.71110955.davem@davemloft.net> (raw)
In-Reply-To: <1302114188.3209.128.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 06 Apr 2011 20:23:08 +0200

> Le mercredi 06 avril 2011 à 11:17 -0700, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Wed, 06 Apr 2011 20:07:33 +0200
>> 
>> > This is why we used on ipv4 :
>> > 
>> > if (inet_sk(sk)->inet_daddr)
>> > 	sock_rps_save_rxhash(sk, skb->rxhash);
>> > 
>> > 
>> > Only arm RFS on UDP if socket is bound to a given remote peer.
>> 
>> Agreed, Neil please make this change to your ipv6 code.
> 
> BTW, do you guys know if NFS is using RFS right now (if TCP transport is
> used) ?

It ought to be.  Are you specifically concerned that it might be
missing the rxhash setting calls because of the APIs it uses to
do socket I/O?

The SunRPC layer is a major user of tcp_read_sock(), for example.

But the packet processing will be done via the normal means,
therefore we'll hit tcp_v4_do_rcv() and therefore save the
rxhash.

  reply	other threads:[~2011-04-06 18:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 17:54 [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets Neil Horman
2011-04-06 18:07 ` Eric Dumazet
2011-04-06 18:17   ` David Miller
2011-04-06 18:23     ` Eric Dumazet
2011-04-06 18:27       ` David Miller [this message]
2011-04-06 18:37         ` Eric Dumazet
2011-04-06 18:40           ` Neil Horman
2011-04-06 18:33       ` Neil Horman
2011-04-06 18:38         ` Eric Dumazet
2011-04-06 18:39   ` Neil Horman
2011-04-06 18:53     ` Brian Haley
2011-04-06 19:19       ` Neil Horman
2011-04-06 19:37 ` [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets (v2) Neil Horman
2011-04-06 20:07   ` David Miller
2011-04-06 20:42     ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110406.112712.71110955.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=pekkas@netcore.fi \
    --cc=therbert@google.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).