From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: joe@perches.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 3/9] tg3: Reintroduce 5717_PLUS
Date: Wed, 06 Apr 2011 11:28:27 -0700 (PDT) [thread overview]
Message-ID: <20110406.112827.104052812.davem@davemloft.net> (raw)
In-Reply-To: <20110406173325.GA14870@mcarlson.broadcom.com>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Wed, 6 Apr 2011 10:33:26 -0700
> For the record though, I did consider using the TG3_FLG3_5717_PLUS flag.
> I'm uncomfortable with using it here because this is more of a server
> class device feature. Should another mobile or desktop device be
> created in the future, I'd have to devise this type of flag to identify
> what feature I'm really talking about. I thought it prudent to just
> take care of that now.
>
> (Not that this is a compelling argument, but it also is a handy way to
> enable and disable the feature while debugging.)
I think the current approach is fine, getting these feature tests right
is indeed non-trivial :-)
I'll apply this patch series to net-next-2.6 and if some tweaks are
still desired, please send them as follow-up patches.
Thanks!
prev parent reply other threads:[~2011-04-06 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 0:22 [PATCH v2 net-next 3/9] tg3: Reintroduce 5717_PLUS Matt Carlson
2011-04-06 5:30 ` Joe Perches
2011-04-06 17:33 ` Matt Carlson
2011-04-06 18:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406.112827.104052812.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).