From: David Miller <davem@davemloft.net>
To: lucian.grijincu@gmail.com
Cc: adobriyan@gmail.com, ebiederm@xmission.com, tavi@cs.pub.ro,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 02/24] sysctl: cookie: add ctl_header_cookie
Date: Wed, 06 Apr 2011 12:53:44 -0700 (PDT) [thread overview]
Message-ID: <20110406.125344.179945750.davem@davemloft.net> (raw)
In-Reply-To: <059405611ddd6d70415081e0261805935e95d345.1301711868.git.lucian.grijincu@gmail.com>
From: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
Date: Sat, 2 Apr 2011 04:53:16 +0200
> @@ -205,6 +205,7 @@ static struct ctl_table_header root_table_header = {
> .ctl_entry = LIST_HEAD_INIT(sysctl_table_root.default_set.list),}},
> .root = &sysctl_table_root,
> .set = &sysctl_table_root.default_set,
> + .ctl_header_cookie = NULL,
> };
Such explicit setting of structure members to NULL in an assignment is
never necessary. Please remove these, there were a few cases in this
patch.
Thanks.
prev parent reply other threads:[~2011-04-06 19:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1301711868.git.lucian.grijincu@gmail.com>
2011-04-02 2:53 ` [PATCH 01/24] sysctl: net: call unregister_net_sysctl_table where needed Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 02/24] sysctl: cookie: add ctl_header_cookie Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 03/24] sysctl: cookie: pass ctl_header_cookie to proc_handler Lucian Adrian Grijincu
2011-04-06 19:54 ` David Miller
2011-04-02 2:53 ` [PATCH 04/24] sysctl: cookie: add netns_proc_dointvec and other netns_proc_* proc_handlers Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 05/24] sysctl: cookie: share ip4_frags_ns_ctl_table between nets Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 06/24] sysctl: cookie: share netns_core_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 07/24] sysctl: cookie: share ipv4_route_flush_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 08/24] sysctl: cookie: share ipv4_net_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 09/24] sysctl: cookie: share ip6_frags_ns_ctl_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 10/24] sysctl: cookie: share ip6_ctl_table, ipv6_icmp_table and ipv6_route_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 11/24] sysctl: cookie: share acct_sysctl_table table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 12/24] sysctl: cookie: share event_sysctl_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 13/24] sysctl: cookie: share nf_ct_sysctl_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 14/24] sysctl: cookie: share unix_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 15/24] sysctl: cookie: share xfrm_table " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 16/24] sysctl: add support for private_children headers Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 17/24] sysctl: add register_net_sysctl_table_with_parent Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 18/24] sysctl: ipv4: register /proc/sys/net/ipv4/conf empty directory Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 19/24] sysctl: ipv4: register devinet tables as private children Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 20/24] sysctl: ipv6: register /proc/sys/net/ipv6/conf empty directory Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 21/24] sysctl: ipv6: register addrconf tables as private children Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 22/24] sysctl: ipv4: register /proc/sys/net/ipv4/neigh empty directory Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 23/24] sysctl: ipv6: register /proc/sys/net/ipv6/neigh " Lucian Adrian Grijincu
2011-04-02 2:53 ` [PATCH 24/24] sysctl: neigh: ipv4 and ipv6 neigh tables as private children Lucian Adrian Grijincu
[not found] ` <05ae3c2fdd2db1f6a2fd3cd900164667e615f4f8.1301711868.git.lucian.grijincu@gmail.com>
2011-04-06 19:52 ` [PATCH 01/24] sysctl: net: call unregister_net_sysctl_table where needed David Miller
2011-04-06 20:04 ` Lucian Adrian Grijincu
2011-04-06 20:06 ` David Miller
[not found] ` <059405611ddd6d70415081e0261805935e95d345.1301711868.git.lucian.grijincu@gmail.com>
2011-04-06 19:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406.125344.179945750.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucian.grijincu@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tavi@cs.pub.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).