From: David Miller <davem@davemloft.net>
To: amit.salecha@qlogic.com
Cc: netdev@vger.kernel.org, ameen.rahman@qlogic.com,
anirban.chakraborty@qlogic.com, bhutchings@solarflare.com
Subject: Re: [PATCHv3 NEXT 1/1] net: ethtool support to configure number of channels
Date: Wed, 06 Apr 2011 12:56:37 -0700 (PDT) [thread overview]
Message-ID: <20110406.125637.70201394.davem@davemloft.net> (raw)
In-Reply-To: <1301720283-25038-1-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Fri, 1 Apr 2011 21:58:03 -0700
> o There exist ETHTOOL_GRXRINGS command for getting number of RX rings,
> but it is tigtly coupled with RX flow hash configuration.
> o Patches for qlcnic and netxen_nic driver supporting rx channel will follow
> soon.
> o This patch is reworked on Ben Hutchings "ethtool: NUMA affinity control" patch,
> dropping the affinity control from it.
>
> Ben Hutching:
> o define 'combined' and 'other' types. Most multiqueue drivers pair up RX and TX
> queues so that most channels combine RX and TX work.
> o Please could you use a kernel-doc comment to describe the structure.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Ben, are you currently OK with this patch?
There was some back and forth, and I just want to make sure all of the
issues you raised were addressed to your satisfaction.
Thanks.
next prev parent reply other threads:[~2011-04-06 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 4:58 [PATCHv3 NEXT 1/1] net: ethtool support to configure number of channels Amit Kumar Salecha
2011-04-06 19:56 ` David Miller [this message]
2011-04-06 20:20 ` Ben Hutchings
2011-04-06 20:30 ` David Miller
2011-04-07 6:03 ` Amit Salecha
2011-04-07 9:41 ` Amit Salecha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406.125637.70201394.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).