netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
	therbert@google.com
Subject: Re: [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets (v2)
Date: Wed, 06 Apr 2011 13:07:49 -0700 (PDT)	[thread overview]
Message-ID: <20110406.130749.35032326.davem@davemloft.net> (raw)
In-Reply-To: <1302118647-7931-1-git-send-email-nhorman@tuxdriver.com>

From: Neil Horman <nhorman@tuxdriver.com>
Date: Wed,  6 Apr 2011 15:37:27 -0400

> properly record sk_rxhash in ipv6 sockets (v2)
> 
> Noticed while working on another project that flows to sockets which I had open
> on a test systems weren't getting steered properly when I had RFS enabled.
> Looking more closely I found that:
> 
> 1) The affected sockets were all ipv6
> 2) They weren't getting steered because sk->sk_rxhash was never set from the
> incomming skbs on that socket.
> 
> This was occuring because there are several points in the IPv4 tcp and udp code
> which save the rxhash value when a new connection is established.  Those calls
> to sock_rps_save_rxhash were never added to the corresponding ipv6 code paths.
> This patch adds those calls.  Tested by myself to properly enable RFS
> functionalty on ipv6.
> 
> Change notes:
> v2:
> 	Filtered UDP to only arm RFS on bound sockets (Eric Dumazet)
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>

Ok, I've decided to apply this to net-2.6

The current behavior even surprised me, I was pretty sure we had added
the hooks to both ipv4 and ipv6.

Thanks a lot Neil.

  reply	other threads:[~2011-04-06 20:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 17:54 [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets Neil Horman
2011-04-06 18:07 ` Eric Dumazet
2011-04-06 18:17   ` David Miller
2011-04-06 18:23     ` Eric Dumazet
2011-04-06 18:27       ` David Miller
2011-04-06 18:37         ` Eric Dumazet
2011-04-06 18:40           ` Neil Horman
2011-04-06 18:33       ` Neil Horman
2011-04-06 18:38         ` Eric Dumazet
2011-04-06 18:39   ` Neil Horman
2011-04-06 18:53     ` Brian Haley
2011-04-06 19:19       ` Neil Horman
2011-04-06 19:37 ` [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets (v2) Neil Horman
2011-04-06 20:07   ` David Miller [this message]
2011-04-06 20:42     ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110406.130749.35032326.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=pekkas@netcore.fi \
    --cc=therbert@google.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).