From: David Miller <davem@davemloft.net>
To: simon@mungewell.org
Cc: gregkh@suse.de, david-b@pacbell.net, sshtylyov@mvista.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PatchV2 : PL25A1 Support - 1/3] whitespace
Date: Wed, 06 Apr 2011 13:17:39 -0700 (PDT) [thread overview]
Message-ID: <20110406.131739.242138705.davem@davemloft.net> (raw)
In-Reply-To: <1302063406-13077-1-git-send-email-simon@mungewell.org>
There are some problems with this patch series:
1) Please compose your subject lines more correctly. When I such these
patches into GIT, everything in the initial "[]" brackets is removed
and the commit header line for this patch (for example) ends up being
just "whitespace".
We want more than that.
Try something like:
Subject: [PATCH v2 1/3] usb: plusb: Whitespace.
Subject: [PATCH v2 2/3] usb: plusb: Add PL25A1 support.
Subject: [PATCH v2 3/3] usb: plusb: Add reset debugging.
2) Patch 2 doesn't apply cleanly to the current tree, you'll need to
refresh these patches.
Thanks.
next prev parent reply other threads:[~2011-04-06 20:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 3:44 [PATCH] pl25a1_support Simon Wood
2011-03-30 9:40 ` David Miller
2011-03-30 11:31 ` Sergei Shtylyov
2011-04-06 4:16 ` [PatchV2 : PL25A1 Support - 1/3] whitespace Simon Wood
2011-04-06 20:17 ` David Miller [this message]
[not found] ` <1301456667-1648-1-git-send-email-simon-wM4F9T/ekXmXDw4h08c5KA@public.gmane.org>
2011-04-06 4:16 ` [PatchV2 : PL25A1 Support - 2/3] add_pl25a1 Simon Wood
2011-04-06 4:16 ` [PatchV2 : PL25A1 Support - 3/3] reset_debug Simon Wood
2011-04-07 7:40 ` [PatchV3 1/3] usb: plusb: Whitespace Simon Wood
2011-04-07 7:40 ` [PatchV3 2/3] usb: plusb: Add support for PL-25A1 Simon Wood
2011-04-11 1:47 ` David Miller
2011-04-07 7:40 ` [PatchV3 3/3] usb: plusb: Add debug to reset function Simon Wood
2011-04-11 1:47 ` David Miller
2011-04-11 1:47 ` [PatchV3 1/3] usb: plusb: Whitespace David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406.131739.242138705.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon@mungewell.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).