netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kurt Van Dijck <kurt.van.dijck-/BeEPy95v10@public.gmane.org>
To: Enric Balletbo i Serra
	<eballetbo-VIneJrwqLopBDgjK7y7TUQ@public.gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org
Subject: Re: [PATCH/RFC] can: mcp251x: Allow pass IRQ flags through platform data.
Date: Wed, 6 Apr 2011 09:14:57 +0200	[thread overview]
Message-ID: <20110406071457.GC284@kurt.e-circ.dyndns.org> (raw)
In-Reply-To: <1302023321-25182-1-git-send-email-eballetbo-VIneJrwqLopBDgjK7y7TUQ@public.gmane.org>

On Tue, Apr 05, 2011 at 07:08:41PM +0200, Enric Balletbo i Serra wrote:
>  	ret = request_threaded_irq(spi->irq, NULL, mcp251x_can_ist,
> -			  IRQF_TRIGGER_FALLING, DEVICE_NAME, priv);
> +		  pdata->irq_flags ? pdata->irq_flags : IRQF_TRIGGER_FALLING,
> +		  DEVICE_NAME, priv);

IMHO, doing like this looks just a tiny bit cleaner
> +		  pdata->irq_flags ?: IRQF_TRIGGER_FALLING,
> +		  DEVICE_NAME, priv);

That's really the only remark :-)

Regards,
Kurt

  parent reply	other threads:[~2011-04-06  7:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 17:08 [PATCH/RFC] can: mcp251x: Allow pass IRQ flags through platform data Enric Balletbo i Serra
     [not found] ` <1302023321-25182-1-git-send-email-eballetbo-VIneJrwqLopBDgjK7y7TUQ@public.gmane.org>
2011-04-06  6:47   ` Wolfgang Grandegger
2011-04-06  6:57   ` Marc Kleine-Budde
2011-04-06  7:14   ` Kurt Van Dijck [this message]
2011-04-06 19:24   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110406071457.GC284@kurt.e-circ.dyndns.org \
    --to=kurt.van.dijck-/beepy95v10@public.gmane.org \
    --cc=eballetbo-VIneJrwqLopBDgjK7y7TUQ@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
    --cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).