From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next] cxgb4: don't hold RTNL during ethtool phys_id Date: Wed, 6 Apr 2011 17:33:08 -0700 Message-ID: <20110406173308.4737e9d4@nehalam> References: <20110406170929.6e427b36@nehalam> <201104061720.30219.leedom@chelsio.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Dimitris Michailidis , Ben Hutchings , David Miller , netdev@vger.kernel.org To: Casey Leedom Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:41408 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755094Ab1DGAeL (ORCPT ); Wed, 6 Apr 2011 20:34:11 -0400 In-Reply-To: <201104061720.30219.leedom@chelsio.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 6 Apr 2011 17:20:29 -0700 Casey Leedom wrote: > | From: Stephen Hemminger > | Date: Wednesday, April 06, 2011 05:09 pm > | > | The Chelsio cxgb4 drivers implement blinking in a unique way by > | waiting on the mailbox. This patch cleans it up slightly by no longer > | holding the system wide network configuration lock during the process. > | > | The patch also uses correct semantics for the time argument > | which is supposed to be in seconds; and zero is supposed > | to signify infinite blinking. > | > | This is still a bad firmware interface design for this > | since it means the board is basically hung while doing the blink. > | But fixing it correctly would require hardware and firmware > | documentation. With that information the device could be converted > | to the new set_phys_id. > | > | Compile tested only. > | > | Signed-off-by: Stephen Hemminger > > Are you assuming that the firmware won't respond with a command completion > until the LED blinking is complete? If so, that's a bad assumption. The > firmware runs as an asynchronous real-time OS. The LED blinking simply becomes > a thread of activity within the OS and the command completes immediately. > > Casey Then how is LED blinking stopped?