From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org
Subject: Re: [PATCH] net: sky2: convert to hw_features
Date: Sun, 10 Apr 2011 13:58:05 -0700 (PDT) [thread overview]
Message-ID: <20110410.135805.71122561.davem@davemloft.net> (raw)
In-Reply-To: <20110410135007.7a4eccdf@nehalam>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Sun, 10 Apr 2011 13:50:07 -0700
> You lost GRO flag in the conversion. Since code calls gro_receive,
> this is necessary.
I think the way it works now is that the generic core turns on
GRO all the time, and this way driver's don't need to be concerned
about it.
next prev parent reply other threads:[~2011-04-10 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 13:13 [PATCH] net: sky2: convert to hw_features Michał Mirosław
2011-04-10 18:49 ` Stephen Hemminger
2011-04-10 18:53 ` Stephen Hemminger
2011-04-11 0:51 ` Michał Mirosław
2011-04-11 14:58 ` Stephen Hemminger
2011-04-11 17:58 ` Michał Mirosław
2011-04-11 18:09 ` Stephen Hemminger
2011-04-11 15:00 ` Stephen Hemminger
2011-04-10 20:50 ` Stephen Hemminger
2011-04-10 20:58 ` David Miller [this message]
2011-04-12 21:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110410.135805.71122561.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).